User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081114 Minefield/3.1b2pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081114 Lightning/1.0pre Shredder/3.0b1pre Since the landing of Bug 414038 the tree lines in folder pane are not correctly shown: No connecting lines between main folders, when sub folders are shown. The tree lines continues also when it's the last folder. It should be a corner. It must be a problem with Bug 414038 because for example DOMi shows all correct. Reproducible: Always

confirmed

Macs don't have treelines, so I'm shooting in the dark here. In theory, this should do it, but I have no way to test.

The patch fixes only interrupted treelines between folders, there are still T-type treelines instead of corners. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081115 Thunderbird/3.0b1pre, checkout start 2008-11-15 14:48:00 CET with the patch <https://bugzilla.mozilla.org/attachment.cgi?id=348318> applied.

The lack of documentation on this method is a substantial problem. From what I can tell from the places tree-view, we should actually be starting a aNextIndex + 1, when searching. This might fix the T-lines. http://mxr.mozilla.org/comm-central/source/mozilla/browser/components/places/content/treeView.js#1090

> Macs don't have treelines, so I'm shooting in the dark here. In theory, this > should do it, but I have no way to test. Oh, but you have! We're better than Apple! ;-) Just put this into your userChrome.css: treechildren::-moz-tree-line {visibility: visible ! important;} (IOW: override the visibility rule in <http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/pinstripe/global/tree.css#155>)

Comment on attachment 348336 [details] [diff] [review] potential patch v2 this definitely looks better, thx.

Pushed as rev 72ea4a5eee81.

Confirming the patch fixes this bug.

This FIXED bug is flagged with in‑testsuite? It would be great if assignee or someone else can clear the flag if a test is not appropriate. And if appropriate, create a test and plus the flag to finish off the bug.