Closed
Bug 465348
Opened 16 years ago
Closed 16 years ago
GrayText color is too dark on 10.5
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b3
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Keywords: verified1.9.1)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jaas
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
GrayText is used as a text color for disabled labels / buttons and search field placeholders.
In nsLookAndFeel.mm it's currently implemented using kThemeTextColorDialogInactive, which returns #7f7f7f on 10.4 (right) but #454545 on 10.5 (wrong).
I'm attaching a patch that uses [NSColor disabledControlTextColor] instead, which seems to work.
Attachment #348562 -
Flags: superreview?(roc)
Attachment #348562 -
Flags: review?(joshmoz)
Attachment #348562 -
Flags: superreview?(roc) → superreview+
Comment on attachment 348562 [details] [diff] [review]
fix v1
+ return NS_RGB((int)([deviceColor redComponent] * 255),
Don't you want to cast that to an unsigned int instead of a signed int, and the same for the other two components? Also, please write "255.0" instead of "255" so it is more clear that you are doing floating point multiplication there.
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #348562 -
Attachment is obsolete: true
Attachment #348657 -
Flags: review?(joshmoz)
Attachment #348562 -
Flags: review?(joshmoz)
Attachment #348657 -
Flags: review?(joshmoz) → review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #348657 -
Flags: approval1.9.1?
|
||
Comment 3•16 years ago
|
||
Comment on attachment 348657 [details] [diff] [review]
v2
a191=beltzner
Attachment #348657 -
Flags: approval1.9.1? → approval1.9.1+
|
||
Comment 4•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
|
||
Comment 5•16 years ago
|
||
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090202 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090202020439
Status: RESOLVED → VERIFIED
|
||
Updated•16 years ago
|
Keywords: fixed1.9.1
|
|
||
Updated•16 years ago
|
Keywords: fixed1.9.1 → verified1.9.1
Target Milestone: mozilla1.9.1b3 → mozilla1.9.2a1
|
|
||
Updated•16 years ago
|
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b3
You need to log in
before you can comment on or make changes to this bug.
Description
•