Closed Bug 465371 Opened 16 years ago Closed 16 years ago

Native JSON stringification aborts on functions and xml but returns JS_TRUE

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bent.mozilla, Assigned: sayrer)

References

Details

(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(2 files)

Patch, v1
(deleted), patch
sayrer
: review-
Details | Diff | Splinter Review
continue, don't break
(deleted), patch
shaver
: review+
Details | Diff | Splinter Review
Attached patch Patch, v1 (deleted) — — Splinter Review
Native JSON stringification aborts on functions and xml but returns JS_TRUE. Patch attached.
Attachment #348590 - Flags: review?(sayrer)
Flags: blocking1.9.1?
Assignee: general → sayrer
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P1
Attachment #348590 - Flags: review?(sayrer) → review+
Attachment #348590 - Flags: review+ → review-
This is ok, and the attached patch is wrong. JSON.stringify(function(){}) should succeed and return undefined. Bug 459161 will take care of the edge cases.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
duh, there was a bug here.
Attached patch continue, don't break (deleted) — — Splinter Review
Attachment #363972 - Flags: review?
Attachment #363972 - Flags: review? → review?(shaver)
Comment on attachment 363972 [details] [diff] [review] continue, don't break I almost found this bug in review, but talked myself out of worrying about that break. :(
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/00d554e3db29
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
covered in json unittests
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: