David Ascher (:davida) Reporter
	Description • 16 years ago

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIAbDirectory.modifyCard]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: chrome://messenger/content/mailWindowOverlay.js :: allowRemoteContentForSender :: line 2305"  data: no]

This is using

Thunderbird 3.0b1pre ID:20081118030209

	Mark Banner (:standard8) Assignee
	Comment 1 • 16 years ago

The issue here is that the card is in the Mac OS X Address Book which is read-only. We're finding that card as part of the lookup routine, and trying to set allow remote content. The modification is then failing due to the read-only.

Rather than fix the Mac OS X address book to be read-write (which we'd like to do anyway), the way we want to fix this bug is by taking the remote content set out of the address book and into its own list as per bug 457296. Therefore setting dependency on fixing that bug.

	Mark Banner (:standard8) Assignee
	Comment 3 • 15 years ago

I think we need to block on this, although maybe we should just block on bug 457296. Either way this is pretty poor for those who do want to use the new Mac OS X address book feature and get emails with remote images in.

	Mitra Ardron
	Comment 5 • 15 years ago

Sorry for the duplicate - was searching on "Allows load remote images" 

In that bug report I suggested that as a workaround it should default to allow remote images from anyone in a non-writable addressbook (i.e. OSX), since that is the normal behaviour that 90% of users will want, i.e. if I've put you in my addressbook I probably want you to be able to send me mail (including with pictures). 

- Mitra

	Mark Banner (:standard8) Assignee
	Comment 6 • 15 years ago

(In reply to comment #5)
> In that bug report I suggested that as a workaround it should default to allow
> remote images from anyone in a non-writable addressbook (i.e. OSX), since that
> is the normal behaviour that 90% of users will want, i.e. if I've put you in my
> addressbook I probably want you to be able to send me mail (including with
> pictures). 

I'm not sure I'd want to do that. It would mean that we'd suddenly be allowing anyone in someones OS X address book to have remote images. Bug 303754 has various thoughts as to why you don't generally want to allow remote images by default.

I realise this isn't going to be perfect, but I think for now we fix this bug so that it ignores read-only address books (when deciding to add or modify), and if we get time, we'll see if we can provide some sort of a wrapper around the OS X address book such that a remote images preference could be stored.

	Mark Banner (:standard8) Assignee
	Comment 7 • 15 years ago

Proposed fix - when trying to find cards to modify, don't care about read-only address books as we're not going to be able to write to them anyway.

As mentioned in my previous comment, this isn't the ideal solution, but at least allows us to not bail out when this situation does occur. The other option is some sort of wrapper around the OS X address book - but I think that's not too easy at this stage.

	Mitra Ardron
	Comment 8 • 15 years ago

I don't know about "not ideal" I don't think this in any way fixes the bug. The problem is not being unable to store preferences it is that you have to click "Display Images" on every message that comes from your close contacts - i.e. the ones in your OSX Address Book. 

I think most people would rather take a risk on an occasional spam image getting through, than have to click the Load Remote Images button every time they get an email from any of their contacts with neither a global nor per-person override.

	Mark Banner (:standard8) Assignee
	Comment 9 • 15 years ago

(In reply to comment #8)
> I don't know about "not ideal" I don't think this in any way fixes the bug. The
> problem is not being unable to store preferences it is that you have to click
> "Display Images" on every message that comes from your close contacts - i.e.
> the ones in your OSX Address Book. 

I think you miss understand the fix (or maybe my description wasn't clear enough). This fix will allow you to allow images from, but will require that the contact is in a read-write address book. So you'll end up with a few duplicates between OS X & your local address book.

The duplicates are why its not ideal, and some sort of wrapper is likely to be the best solution, but I doubt we will get time for that (though I will follow a file up bug that will be wanted TB 3).

	Mark Banner (:standard8) Assignee
	Comment 10 • 15 years ago

Comment on attachment 369642 [details] [diff] [review]
Proposed fix

I just realised, Magnus is afk until after m2.

	Bryan Clark (DevTools PM) [:clarkbw]
	Comment 11 • 15 years ago

Comment on attachment 369642 [details] [diff] [review]
Proposed fix

ugly, but better than hideous :)

	Mitra Ardron
	Comment 12 • 15 years ago

Ick - we've just got rid of all but one of the TB bugs requiring duplicates, (the one about more than two email addresses) this would require a lot of fiddling - i.e. any time you get an email with images, you have to add it to an address book, then select the "always allow".

That's a fair amount of fiddling - probably almost as bad as clicking on Almost Allow each time 
and ...
I don't think most users will figure it out - they'll just be frustrated at the images not showing up?

I still think the privacy implications of a remote image are less of an issue than the UI issues. 
- Mitra

	Magnus Melin [:mkmelin]
	Comment 13 • 15 years ago

Comment on attachment 369642 [details] [diff] [review]
Proposed fix

Looks good from code inspection.

>+      // If its a read-only book, don't find a card as we won't be able

Nit: it's

	Mark Banner (:standard8) Assignee
	Comment 14 • 15 years ago

Checked in: http://hg.mozilla.org/comm-central/rev/fcb8b1d60424

I raised bug 486479 for doing a wrapper or something around read-only address books which would improve the situation.