Martijn Korse Reporter
	Description • 16 years ago

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.18) Gecko/20081029 Firefox/2.0.0.18
Build Identifier: 

Even though a max-height for a description tag (with multiline=true) is specified, the contents will still exceed this height. And this problem cannot be fixed with overflow-y: hidden;

This bug is new in FF 3.x - it seemed to work correctly in 2.x versions

Reproducible: Always

Steps to Reproduce:
1. Create a <description multiline="true"> and set a max-height in the stylesheet of a certain amount of pixels.
2. Fill the description-tag with content; put this between the opening and closing tag, like this: <description multiline="true">content</description> (don't use the value="" method)
3. Make sure the content is bigger then what fits given the max-height.
4. Optionally set overflow-y: hidden in the stylesheet - this doens't have any effect though
Actual Results:  
The contents spill over the border defined by the max-height.

Expected Results:  
In FF 2.x the contents that exceed the max-height were not shown. I expected the same behaviour in FF 3.x
I can understand though, that the contents outside this region are also shown - but in this case i would expect the overflow-y: hidden to prevent this from being shown.

	Martijn Korse Reporter
	Comment 1 • 16 years ago

This testcase shows the difference between how it was rendered in Firefox 2.x and how it is now rendered in Firefox 3.x
I would expect both to be the same and how it was done in Firefox 2.x

	Ria Klaassen (not reading all bugmail)
	Comment 2 • 16 years ago

Regression range is http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-01-25+16%3A00&maxdate=2006-01-26+10%3A00

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 3 • 16 years ago

The bug here is really that overflow-y:hidden doesn't work.

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 4 • 16 years ago

Wrapping the block frame in an nsHTMLScrollFrame is easy enough. But it leads to some weirdness in the box/block interaction code, which is a real disaster area.

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 5 • 16 years ago

Here's a patch. I think it's a logical change, but I'm reluctant to land it because it changes other behaviour, and I'm afraid that will lead to a cascade of regressions as we try to patch around the completely broken box/block interaction. I'll attach a testcase in a moment.

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 6 • 16 years ago

The patch sort-of regresses this testcase. On trunk the max-height does limit the element height to 50px, although we don't clip to overflow:hidden (and the width is not limited to 10px). With the patch, the element height becomes the height of a single line.

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 7 • 16 years ago

Another option here is to allow box-wrapped blocks to clip for overflow:hidden but not support overflow:scroll/auto. But that seems not really worth doing. I think I'd rather leave this until we have sane box/block interaction.

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 8 • 16 years ago

So, taking off wanted list.

	Michelle Funches - QA
	Comment 9 • 8 years ago

Hi Robert: I am miss-understanding the issue? Please let me know if I can assist with testing this issue.
Version 	47.0.1
Build ID 	20160623154057
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0