Closed
Bug 466510
Opened 16 years ago
Closed 16 years ago
Can't create saved search or view folder; openNewVirtualFolderDialogWithArgs is not defined
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b1
People
(Reporter: philor, Assigned: Bienvenu)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
jminta
:
review+
standard8
:
superreview+
|
Details | Diff | Splinter Review |
Fallout from bug 414038, which removed openNewVirtualFolderDialogWithArgs from widgetglue.js.
1. Search in quicksearch
2. From the menu select Save Search as a Folder
or
1. Add the View widget to the toolbar
2. Select something like Last 5 Days
3. Select Save View as a Folder
Actual:
Nothing happens other than:
Error: openNewVirtualFolderDialogWithArgs is not defined
Source File: chrome://messenger/content/msgViewPickerOverlay.js
Line: 76
Flags: blocking-thunderbird3.0b1?
|
Assignee | |
Comment 1•16 years ago
|
||
blocking b1
Flags: blocking-thunderbird3+
Target Milestone: --- → Thunderbird 3.0b1
|
||
Comment 2•16 years ago
|
||
You probably want gFolderTreeController.newVirtualFolder() instead.
|
|
Assignee | |
Comment 3•16 years ago
|
||
thx, Joey, I'll take a quick whack at this.
Assignee: nobody → bienvenu
|
Reporter | |
Comment 4•16 years ago
|
||
Though since one of the callers is in mailnews/extensions/, you probably "want"
a openNewVirtualFolderDialogWithArgs() which passes the Args to
.newVirtualFolder() :/
|
|
||
Comment 5•16 years ago
|
||
Or save some global scope and do like so: http://mxr.mozilla.org/comm-central/source/mailnews/base/resources/content/mailWidgets.xml#1863
|
|
Assignee | |
Comment 6•16 years ago
|
||
standard, just need sr for the mailnews/extensions/mailview part since its shared code, thx!
Attachment #349797 -
Flags: superreview?(bugzilla)
Attachment #349797 -
Flags: review?(jminta)
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [has patch for review]
|
|
||
Updated•16 years ago
|
Attachment #349797 -
Flags: review?(jminta) → review+
|
|
||
Comment 7•16 years ago
|
||
Comment on attachment 349797 [details] [diff] [review]
proposed fix
Wrapping the args so they're < 80chars would be nice.
|
|
Assignee | |
Comment 8•16 years ago
|
||
I've wrapped them locally...
Whiteboard: [has patch for review] → [needs sr Standard8]
|
|
Reporter | |
Updated•16 years ago
|
Flags: blocking-thunderbird3.0b1?
|
||
Updated•16 years ago
|
Attachment #349797 -
Flags: superreview?(bugzilla) → superreview+
|
|
||
Updated•16 years ago
|
Whiteboard: [needs sr Standard8] → [bienvenu to land patch]
|
|
Assignee | |
Comment 9•16 years ago
|
||
fix checked in.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [bienvenu to land patch]
You need to log in
before you can comment on or make changes to this bug.
Description
•