Jesse Ruderman Reporter
	Description • 16 years ago

###!!! ASSERTION: FlushUserFontSet should have been called first: '!mGetUserFontSetCalled', file /Users/jruderman/central/layout/base/nsPresContext.cpp, line 1715

This assertion was added in "patch 2-3-4" of 457821.

I'm hitting this frequently in my testing, but I can ignore it easily.

	David Baron :dbaron: Assignee
	Comment 1 • 16 years ago

I suppose my inclination is to remove the assertion.

It's firing when we're constructing frames during a ContentAppended notification, but we're only actually calling FlushUserFontSet when we get a Flush_Layout, which we don't need to do to construct frames.  That said, on entering ContentAppended we don't do any flush at all.

bzbarsky, thoughts?

	David Baron :dbaron: Assignee
	Comment 2 • 16 years ago

bzbarsky pointed out that I could use IsReflowLocked here...

	Boris Zbarsky [:bzbarsky]
	Comment 3 • 16 years ago

Comment on attachment 350224 [details] [diff] [review]
patch

Looks good.

	Jesse Ruderman Reporter
	Comment 4 • 16 years ago

You might want to use "#ifdef DEBUG" to avoid introducing an unused variable in non-debug builds.

	David Baron :dbaron: Assignee
	Comment 5 • 16 years ago

Comment on attachment 350224 [details] [diff] [review]
patch

Fixes up an assertion from a patch landed yesterday.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 6 • 16 years ago

Comment on attachment 350224 [details] [diff] [review]
patch

a191=beltzner

	Shawn Wilsher :sdwilsh
	Comment 8 • 16 years ago

http://hg.mozilla.org/mozilla-central/rev/65174df9c1bb

	Aakash Desai [:aakashd]
	Comment 9 • 15 years ago

pushed: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/65174df9c1bb

verified FIXED using testcase on builds: 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090505 Minefield/3.6a1pre ID:20090505030940

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090505 Shiretoko/3.5b5pre ID:20090505030932