Closed Bug 466900 Opened 16 years ago Closed 16 years ago

list of session tabs to restore is empty (tabData.attributes can be missing for loading tabs)

Categories

(Firefox :: Session Restore, defect)

3.5 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3.6a1

People

(Reporter: wsmwk, Unassigned)

References

Details

(Keywords: verified1.9.1)

Attachments

(1 file)

Beta 2 rc1 Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2) Gecko/20081125 Firefox/3.1b2 list of session tabs to restore is empty STR 1. kill FF 20081106 trunk build process - ~200 tabs in 26 windows 2. restart with FF3.1 build, it restored everything, but did not present the session restore tab 3. force enabled several extensions in addons (using nightly tester tools) 4. kill FF 3.1 process 5. start FF 3.1 Results: Got a session restore tab, but the list of tabs to be restored was empty/blank did not attempt to reproduce. Note: I have not seen this problem when using FF trunk.
(In reply to comment #0) > did not attempt to reproduce. Please try to. But first, please make a copy of sessionstore.bak if you haven't yet restarted it another time. Copying that file over sessionstore.js before startup should place you once again right after your step #4. And if the list of tabs to restore remains empty, please e-mail me that file for further debugging; or if you get any errors in the Error Console, please list these here.
Keywords: qawanted
Attached image sessionrestore screen shot (deleted) —
(I have saved the sessionstore.bak from comment 0) reproduced with same STR, same URLS but fewer (comment 0 testcase but closed a bunch before my system hung - a different story) - then restart) - ~23 windows, ~180 tabs. Same results. I will email you the sessionstore file. I have not yet tried in a clean profile using copy of sessionstore. my list of extensions, all of which have been running OK under FF 3.0 and trunk (with version override) ------------------------------ Greasemonkey 0.8.20080609.0 Nightly Tester Tools 2.0.2 SQLite Manager 0.4.0 Tab Kit 0.4.3 TabCounter 1.0.3 Tabhunter 0.6.9 Copy All Urls 0.8.0 [DISABLED] Delicious Bookmarks 2.0.104 [DISABLED] Flashblock 1.5.6 [DISABLED] Foxmarks Bookmark Synchronizer 2.5.3 [DISABLED] Go Parent Folder 1.6 [DISABLED] Groowe Search Toolbar 1.6.5 [DISABLED] Internote 2.1.5 [DISABLED] MyStickies 0.1.7 [DISABLED] Pencil 1.0.2 [DISABLED] Send Tab URLs 1.0 [DISABLED] Show Parent Folder 1.3 [DISABLED] TabAway 2 [DISABLED] tabsearch 0.1 [DISABLED] TagSifter 4.1.1 [DISABLED] TinyUrl Creator 2.0 [DISABLED] Who Is This Person? 1.1.1 [DISABLED]
Thanks. The issue is that we seem to somehow be able to miss collecting a tab's attributes while it's still loading - but we rely on them being present for displaying the favicons in about:sessionrestore. When this happens, you should get the following error message: Error: aTabData.attributes is undefined Source File: chrome://browser/content/aboutSessionRestore.js Line: 85 The patch for bug 462863 would fix this issue.
Status: UNCONFIRMED → NEW
Depends on: 462863
Ever confirmed: true
Keywords: qawanted
Summary: list of session tabs to restore is empty → list of session tabs to restore is empty (tabData.attributes can be missing for loading tabs)
I don't see aTabData.attributes is undefined in console. Does console wrap? (too bad can't search it) I'll be looking at restart further because I have two other problems: 1. the restart from comment 0 took 200-300MB more memory than expected 2. the restart from comment 2 is pulling a constant 8-9% cpu, still an hour after restart.
(In reply to comment #4) > I don't see aTabData.attributes is undefined in console. Does console wrap? Is javascript.options.showInConsole set to true? The console wraps at 250 entries, which should be more than enough to catch this. > (too bad can't search it) Console² <https://addons.mozilla.org/firefox/1815> is your friend (it'll also make it easier to set/unset the above pref).
Same happened to me with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2 ID:20081201061100 I tried the testcase on bug 467007 which let your browser crash when Adblock is installed. Doing it twice and starting Firefox again I always get a list with no windows and tabs listed. But clicking on Restore does its job and restores everything. Asking for blocking1.9.1...
Flags: blocking-firefox3.1?
OS: Windows XP → All
Hardware: PC → All
bug 462863 has landed, can we retest this? Simon's comment suggests this should be fixed.
Flags: blocking-firefox3.1?
Yes, its fixed for 3.2a1 but the patch hasn't been landed on 1.9.1 yet. It's still waiting for approval. Will ask for blocking1.9.1 over there.
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: blocking-firefox3.1?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Status: RESOLVED → VERIFIED
Flags: blocking-firefox3.1?
Sorry, but I forgot to mention: Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20081214 Minefield/3.2a1pre ID:20081214020505 Would even be a good candidate as a Litmus test.
Flags: in-litmus?
Verified on 1.9.1 with: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20081224 Shiretoko/3.1b3pre ID:20081224020421 Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081224 Shiretoko/3.1b3pre ID:20081224042714
Keywords: verified1.9.1
Henrik, could you please verify which add-ons you had installed, how many windows and tabs you had opened, STR, etc used to verify this bug? I need this information for writing the litmus test case.
Installed add-ons don't matter. It should even not happen for a fresh profile. You can install the crashme extension and kill Firefox twice in a row while pages in tabs are loading. The sessionstore page should list your tabs after the second restart.
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: