Stefan [:stefanh] Assignee
	Description • 16 years ago

SeaMonkey's Composer uses bottom tabs with list-style-images directly on the tab element. Those images are now stretched. See bug 378202 where this was originally fixed.

I think it's the combination of removing the "-moz-box-align: center;" for ".tab-bottom" and adding the below rule in tabbox.css that causes the images to be stretched:

89 tabbox.tabs-bottom > tabs > tab > .tab-middle,
90 tabs.tabs-bottom > tab > .tab-middle {
91   -moz-box-align: stretch;

This could probably be fixed on an app-specific level, but I'm filing this here since I think it should be possible to have icons in bottom tabs.

	Stefan [:stefanh] Assignee
	Comment 1 • 16 years ago

This should be the easiest and safest way to fix this (I don't want to mess up Markus stuff too much), I think. I've tested this in cz and it doesn't seem to change anything. It's also probably good to eliminate the risk of other things being vertically stretched.

	Stefan [:stefanh] Assignee
	Comment 2 • 16 years ago

Comment on attachment 350786 [details] [diff] [review]
One-liner, just use -moz-box-align: center

Dao said he could look at this.

	Stefan [:stefanh] Assignee
	Comment 3 • 16 years ago

Here's a testcase.

	Dão Gottwald [:dao]
	Comment 4 • 16 years ago

Doesn't this apply to normal tabs as well due to tab { -moz-box-align: stretch; }?

	Stefan [:stefanh] Assignee
	Comment 5 • 16 years ago

Comment on attachment 350786 [details] [diff] [review]
One-liner, just use -moz-box-align: center

(In reply to comment #4)
> Doesn't this apply to normal tabs as well due to tab { -moz-box-align: stretch;
> }?

True. Hmm, I guess I could use "center" on .tab-middle. Not sure if I dare to center everything inside the whole tab.

	Dão Gottwald [:dao]
	Comment 6 • 16 years ago

-moz-box-align:stretch isn't needed in the first place, is it?

	Stefan [:stefanh] Assignee
	Comment 7 • 16 years ago

(In reply to comment #6)
> -moz-box-align:stretch isn't needed in the first place, is it?

You're right. And xul.css uses "-moz-box-align: center".

	Stefan [:stefanh] Assignee
	Comment 8 • 16 years ago

Hmm... .tabbrowser-tab in browser seems to have it too...

	Stefan [:stefanh] Assignee
	Comment 9 • 16 years ago

OK, this is much better. Since we have "-moz-box-align: center" and "-moz-box-pack: center" in xul.css, tabbrowser-tab doesn't need it, so I removed the style rules from browser.css. I also moved the .tab-middle rule (no reason to use tab > .tab-middle) down a bit, to keep it together with the other classes. I think for icons in bottom tabs to look really good, some extra polish might be necessary. I still haven't figured out how to do this without changing the look of the tabs, though, so I guess that'll have to wait.

	Stefan [:stefanh] Assignee
	Comment 10 • 16 years ago

(In reply to comment #9)

> I still haven't figured out how to do this without
> changing the look of the tabs

This should of course be interpreted as "I still haven't figured out how to do this in a decent way without..." ;-)

	Stefan [:stefanh] Assignee
	Comment 11 • 16 years ago

Pushed c79c596ea42f to mozilla-central.

	Dão Gottwald [:dao]
	Comment 12 • 16 years ago

Comment on attachment 351416 [details] [diff] [review]
New version

We should take this on branch, since it doesn't only affect bottom tabs.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 13 • 16 years ago

Comment on attachment 351416 [details] [diff] [review]
New version

a191=beltzner

	Dão Gottwald [:dao]
	Comment 14 • 16 years ago

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d36eea60cb3d