Closed
Bug 467441
Opened 16 years ago
Closed 16 years ago
unnecessary js_AddRoot for regex statics
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
References
Details
(Keywords: fixed1.9.0.11, fixed1.9.1, Whiteboard: fixed-in-tracemonkey)
Attachments
(2 files)
|
(deleted),
patch
|
crowderbt
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
dveditz
:
approval1.9.0.11+
|
Details | Diff | Splinter Review |
Currently js_InitRegExpStatics uses js_AddRoot to root JSContext.regExpStatics->input. This is unnecessary since the GC can trace the statics directly from js_TraceContext avoiding the need to create entries in the global root table.
|
Assignee | |
Comment 1•16 years ago
|
||
The patch replaces js_(Add|Remove)Root with the explicit GC tracing and moves all regexp-specific initialization for JSContext to jsregexp.cpp.
Attachment #350880 -
Flags: review?(crowder)
|
||
Updated•16 years ago
|
Attachment #350880 -
Flags: review?(crowder) → review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
pushed to TM - http://hg.mozilla.org/tracemonkey/rev/efd7691d238a
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•16 years ago
|
||
merged to mc
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•16 years ago
|
||
Flags: wanted1.9.1+
Keywords: fixed1.9.1
|
||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
|
||
Comment 5•16 years ago
|
||
|
|
||
Updated•16 years ago
|
Attachment #366884 -
Flags: approval1.9.0.10?
|
|
||
Comment 6•16 years ago
|
||
Comment on attachment 366884 [details] [diff] [review]
backport to 1.9.0 (for SpiderMonkey 1.8 source release)
Patch 2/4 to fix a crashing bug for embedders that blocks the SpiderMonkey 1.8 source release. See bug 478336 comment 21 for the full list.
|
||
Comment 7•16 years ago
|
||
Comment on attachment 366884 [details] [diff] [review]
backport to 1.9.0 (for SpiderMonkey 1.8 source release)
Approved for 1.9.0.10, a=dveditz for release-drivers
Attachment #366884 -
Flags: approval1.9.0.10? → approval1.9.0.10+
|
|
Assignee | |
Comment 8•16 years ago
|
||
landed to 1.9.0:
Checking in jscntxt.c;
/cvsroot/mozilla/js/src/jscntxt.c,v <-- jscntxt.c
new revision: 3.137; previous revision: 3.136
done
Checking in jsgc.c;
/cvsroot/mozilla/js/src/jsgc.c,v <-- jsgc.c
new revision: 3.304; previous revision: 3.303
done
Checking in jsregexp.c;
/cvsroot/mozilla/js/src/jsregexp.c,v <-- jsregexp.c
new revision: 3.202; previous revision: 3.201
done
Checking in jsregexp.h;
/cvsroot/mozilla/js/src/jsregexp.h,v <-- jsregexp.h
new revision: 3.31; previous revision: 3.30
done
Keywords: fixed1.9.0.10
You need to log in
before you can comment on or make changes to this bug.
Description
•