Closed
Bug 467477
Opened 16 years ago
Closed 15 years ago
View Source should linkify xlink:href
Categories
(Core :: XML, enhancement)
Core
XML
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: longsonr)
References
()
Details
(Keywords: testcase)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
SVG documents use xlink:href for hyperlinks and for many types of resources (e.g. <svg:use>). View Source should linkify these URLs like it does for hyperlinks and resources in HTML and XHTML documents.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: nobody → longsonr
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #416859 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Attachment #416860 -
Flags: review?(mrbkap)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 416860 [details] [diff] [review]
patch
>diff --git a/parser/htmlparser/src/nsViewSourceHTML.cpp b/parser/htmlparser/src/nsViewSourceHTML.cpp
> PRBool isSrc = !isHref && trimmedAttrName.LowerCaseEqualsLiteral("src");
>+ isSrc |= (mDocType == eXML && trimmedAttrName.EqualsLiteral("xlink:href"));
I'd rather see you add isXLink and return isHref || isSrc || isXLink at the end of the function.
r=mrbkap with that.
Attachment #416860 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #416860 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•