Closed
Bug 467629
Opened 16 years ago
Closed 16 years ago
SVG Repaint issue part 2 (ellipse)
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
INVALID
People
(Reporter: longsonr, Assigned: longsonr)
References
Details
Attachments
(2 obsolete files)
No description provided.
|
Assignee | |
Comment 1•16 years ago
|
||
Comment on attachment 351044 [details] [diff] [review]
patch with reviewed ellipse change from bug 459148
For review information see bug 459148
Attachment #351044 -
Flags: approval1.9.1?
|
|
Assignee | |
Updated•16 years ago
|
Flags: blocking1.9.1?
|
|
Assignee | |
Comment 2•16 years ago
|
||
Comment on attachment 351044 [details] [diff] [review]
patch with reviewed ellipse change from bug 459148
probably should just block like the other patch
Attachment #351044 -
Flags: approval1.9.1?
Attachment #351044 -
Flags: superreview+
Attachment #351044 -
Flags: review+
Comment on attachment 351044 [details] [diff] [review]
patch with reviewed ellipse change from bug 459148
+ if (rx > 0.0f && ry > 0.0f)
+ aCtx->Ellipse(gfxPoint(x, y), gfxSize(rx*2, ry*2));
Put {} around the statement
You could add a test here covering ellipse and circle
Flags: blocking1.9.1? → blocking1.9.1+
|
|
Assignee | |
Comment 5•16 years ago
|
||
No test yet but that may come from bug 465996
Attachment #351044 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•16 years ago
|
||
This is not the right thing to do.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
|
|
Assignee | |
Updated•16 years ago
|
Attachment #351219 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•