I'm doing these so we've got a slightly saner implementation for when I alter stuff for the password manager switch. This changes some of the string interfaces from string to ACString. Not going with AUTF8String at this stage, as that will adjust the current functionality which I don't want to do without specific testing for l18n issues.

Comment on attachment 351428 [details] [diff] [review] The fix >- if (*aUsername && **aUsername) >- return rv; >- >- // empty username >- NS_Free(*aUsername); >- *aUsername = 0; >+ if (aUsername.IsEmpty()) >+ return rv; !aUsername.IsEmpty() surely? >+ return mPrefBranch->SetCharPref("hostname", nsCString(aHostname).get()); Nit: please use PromiseFlatCString (2×). >+ uri.AssignLiteral("smtp"); >+ uri.AppendLiteral("://"); AssignLiteral("smtp://"); Should this need to support smtps:// in the future, I think we can live with an if choosing between the two literals ;-)

Checked in with comments addressed. http://hg.mozilla.org/comm-central/rev/1e7d1a981aa2

I had to revert some of the ways we return values from the Set* functions that I altered; changeset: http://hg.mozilla.org/comm-central/rev/89b309ce721c I also added a comment as to why.