Thunderbird 3.0 Beta 1, BuildID=20081204113938, Mac OS 10.5.5 there is no undo for deleted saved searches

this is true - that's why there's a confirmation dialog.

there is also no confirmation dialog on Thunderbird 3.0 Beta 1 / Mac

ugh, there used to be. The new folder pane must have broken that. I think I'm going to hijack this bug for that regression. It's not quite as bad as it used to be because we've changed delete to only work on folders if no messages are selected, but it's still not good. In fact, we've lost the confirmation dialog on deleting from the trash as well.

we used to do this here: http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMsgFolderDataSource.cpp#2013 but now we don't go through the folder data source, so we'll need to do it in folderPane.js, or the backend somewhere...

Comment on attachment 358661 [details] [diff] [review] proposed fix + if ((Components.classes["@mozilla.org/embedcomp/prompt-service;1"] + .getService(IPS) + .confirmEx(window, title, confirmation, IPS.STD_YES_NO_BUTTONS + IPS.BUTTON_POS_1_DEFAULT, + "", "", "", "", {})) != 0) /* the yes button is in position 0 */ There looks to be an extra set of parens wrapping just the function call? r=jminta with those removed if that's the case.

I looked and we don't confirm deletion from trash in 2.0x, so the regression was really just the virtual folder delete. Fix checked in, with extra parens removed.