From bug 382187 comment #58: > >+ var URIslice = URIs.slice(i, Math.max(i + REMOVE_PAGES_CHUNKLEN, URIs.length)); > Whoa, this should be Math.min As far as I can tell this means the first loop removes all of aURIs, and the subsequent iterations call removePages for progressively smaller chunks of already removed URIs. As Neil pointed out in the bug, the Math.min isn't necessary at all, you can just always pass in i + REMOVE_PAGES_CHUNKLEN.

The practical effects of this bug that I forgot to mention in comment 0 is that deleting a lot of history items is slower than it needs to be, and potentially causes the browser to lock up or show a slow script warning.

In fact, this might be the cause of bug 466421.

many thanks!

Hwv this won't solve the slow script, that is mostly due to persisting selection in the treeView (see _refreshVisibleSection, we can take a look there in bug 466421), hwv it is reducing them a lot, for removing 16000 items i get only 1 slow script now (due to the final loop that do a batch notify that updates the treeview).

pushed to trunk: http://hg.mozilla.org/mozilla-central/rev/1e8779804b50

Comment on attachment 351677 [details] [diff] [review] patch approval or blocking please, this was broken code.

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090127 Shiretoko/3.1b3pre

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv