Closed
Bug 468476
Opened 16 years ago
Closed 16 years ago
errors in reftest manifest should print TEST-UNEXPECTED-FAIL
Categories
(Testing :: Reftest, defect)
Testing
Reftest
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
There was just an error in a reftest manifest for 9 hours, and the reftests were printing "5/0/0" because they were scraping the following log:
REFTEST TEST-FAIL | | EXCEPTION: Error in manifest file file:///builds/slave/trunk_linux-7/build/layout/reftests/text/reftest.list line 28
REFTEST FINISHED: Slowest test took 0ms (undefined)
REFTEST INFO | Result summary:
REFTEST INFO | Exception: 1
REFTEST INFO | Total canvas count = 0
program finished with exit code 0
TinderboxPrint: reftest<br/>5/0/0
The EXCEPTION print should at least print TEST-UNEXPECTED-FAIL so it turns the tree orange and we notice. (Maybe we should fix the other math problems by doing bug 468023, or maybe other ways.)
Attachment #351926 -
Flags: review?(ted.mielczarek)
|
||
Updated•16 years ago
|
Attachment #351926 -
Flags: review?(ted.mielczarek) → review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 351926 [details] [diff] [review]
patch
Sorry, I guess I missed that when I changed things?
|
Assignee | |
Comment 2•16 years ago
|
||
Fixed on m-c: http://hg.mozilla.org/mozilla-central/rev/84231c3b7ad4
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
|
Assignee | |
Comment 3•16 years ago
|
||
Fixed on mozilla-1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f5fc2bc812e2
Keywords: fixed1.9.1
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b3
|
|
Assignee | |
Updated•16 years ago
|
Component: Layout: Misc Code → Reftest
Product: Core → Testing
QA Contact: layout.misc-code → reftest
Target Milestone: mozilla1.9.1b3 → ---
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•