Closed Bug 468507 Opened 16 years ago Closed 16 years ago

Use DrawCellWithSnapping when drawing push buttons

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Keywords: fixed1.9.1)

Attachments

(2 files, 2 obsolete files)

Screenshot of google.de with patch
(deleted), image/png
Details
for checkin
(deleted), patch
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
Attached patch v1 (obsolete) (deleted) — — Splinter Review
This patch is on top of that in bug 462233.
Attachment #351971 - Flags: review?(joshmoz)
Attached patch v2, always use 0.5 as offset factor (obsolete) (deleted) — — Splinter Review
Looking at the vertical align property in order to determine the snapping direction is a bad idea, since the text on the button might not be centered in the button any more. Now I always center it.
Attachment #351971 - Attachment is obsolete: true
Attachment #351973 - Flags: review?(joshmoz)
Attachment #351971 - Flags: review?(joshmoz)
Attached image Screenshot of google.de with patch (deleted) —
Note that the buttons aren't blurry any more.
Markus, will this also fix bug 384830? (There's also a bug out there, or maybe just a comment in a related bug, about the blurriness of the current scaling, though I can't find it right now.)
(In reply to comment #3) > Markus, will this also fix bug 384830? I think that bug is already fixed.
Attachment #351973 - Flags: review?(joshmoz)
Attachment #351973 - Flags: superreview?(dbaron)
Attachment #351973 - Flags: review?(joshmoz)
Comment on attachment 351973 [details] [diff] [review] v2, always use 0.5 as offset factor sr=dbaron, although if there was something particularly interesting that you wanted my opinion about, you should ask me explicitly...
Attachment #351973 - Flags: superreview?(dbaron) → superreview+
Attachment #351973 - Flags: review?(joshmoz) → review+
Attached patch for checkin (deleted) — — Splinter Review
Attachment #351973 - Attachment is obsolete: true
Keywords: checkin-needed
pushed: http://hg.mozilla.org/mozilla-central/rev/a4cc5f89569d
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Comment on attachment 356477 [details] [diff] [review] for checkin Small polish fix (buttons in their default size no longer look blurry), quite safe.
Attachment #356477 - Flags: approval1.9.1?
Comment on attachment 356477 [details] [diff] [review] for checkin a191=beltzner
Attachment #356477 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: