Closed
Bug 468717
Opened 16 years ago
Closed 16 years ago
Re-enable static analysis for js/src
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jorendorff, Assigned: benjamin)
References
Details
(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jorendorff
:
review+
sayrer
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Static analysis is disabled for everything under js/src. I just landed an analysis mostly aimed at js/src in bug 460865. It would be nice to be able to run it again!
http://hg.mozilla.org/mozilla-central/file/4b4ee8b2dc54/js/src/config/static-checking-config.mk
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → benjamin
|
|
Assignee | |
Comment 1•16 years ago
|
||
jorendorff, do you have a test-suite for your cx->fp checker? I'd really like to get that checked in as well, because the analysis scripts tend to be fragile and the testsuites are really good at making sure the analysis works.
Attachment #352306 -
Flags: review?(jorendorff)
|
Reporter | |
Comment 2•16 years ago
|
||
Comment on attachment 352306 [details] [diff] [review]
Make static checking work in js/src, rev. 1
> -// XXXbugfix: when you pass arguments to -fplugin-arg, include_path[0] is bad
> -sys.include_path[0] = options.topsrcdir + "/xpcom/analysis";
> sys.include_path.push(options.topsrcdir);
>
> include('string-format.js');
...
> diff --git a/xpcom/analysis/string-format.js b/config/string-format.js
> rename from xpcom/analysis/string-format.js
> rename to config/string-format.js
Should the include change to 'config/string-format.js'?
> --- a/js/src/config/static-checking-config.mk
> +++ b/js/src/config/static-checking-config.mk
> @@ -1,24 +1,25 @@
> # Currently spidermonkey has no static checking infrastructure, but it will...
> # This is all dummy values now: see the Mozilla version of this file for
> # an example with real data.
Please update the comment.
|
|
Reporter | |
Comment 3•16 years ago
|
||
I don't have a test suite yet, but I'll file a bug for it. Can you point me at existing test suites for other analyses?
|
|
Assignee | |
Comment 4•16 years ago
|
||
I've removed the stale comment. It is not necessary to include topsrcdir/config/string-format.js because the directory of the script (static-checking.js) is always in the include path.
Attachment #352306 -
Attachment is obsolete: true
Attachment #352353 -
Flags: review?(jorendorff)
Attachment #352306 -
Flags: review?(jorendorff)
|
|
Reporter | |
Updated•16 years ago
|
Attachment #352353 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 5•16 years ago
|
||
Pushed to tracemonkey, http://hg.mozilla.org/tracemonkey/rev/515cba6cd88a
What are we doing nowadays with bugs fixed on tracemonkey but not yet on m-c? Is there a keyword or some other magic annotation so that they get marked FIXED when the next TM->m-c merge is done?
|
||
Comment 6•16 years ago
|
||
whiteboard: fixed-in-tracemonkey
but, I just pushed this to m-c
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-tracemonkey
|
|
||
Updated•16 years ago
|
Attachment #352353 -
Flags: approval1.9.1+
|
|
||
Updated•16 years ago
|
Keywords: fixed1.9.1
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•