Closed
Bug 468754
Opened 16 years ago
Closed 12 years ago
getItemIdForGUID ignores anno name
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
INVALID
People
(Reporter: hello, Assigned: wesongathedeveloper)
References
Details
(Whiteboard: [weave][good first bug])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
The mDBGetItemIdForGUID SQL statement:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavBookmarks.cpp#295
Does not use the guid anno name ("placesInternal/GUID"). Seems to me this could return other items which have a different anno with the same value.
Of course, that is unlikely, but possible given some hypothetical extension that saves e.g., "myext/related" with the value being a related GUID.
Updated•16 years ago
|
Whiteboard: [weave][good first bug]
Comment 1•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
Assignee | ||
Comment 2•14 years ago
|
||
Assignee: nobody → wesongathedeveloper
Status: NEW → ASSIGNED
Attachment #451660 -
Flags: review?(mak77)
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 451660 [details] [diff] [review]
Patch
let me see if I can compose a test for this...
Attachment #451660 -
Flags: review?(mak77)
Comment 5•14 years ago
|
||
you should use the GUID_ANNO macro. Yes, the test should not be too hard to do.
Flags: in-testsuite?
Comment 6•12 years ago
|
||
this API died quite some time ago
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
Updated•9 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•