Closed
Bug 468836
Opened 16 years ago
Closed 16 years ago
Existing tags no longer show and cannot be edited
Categories
(Firefox :: Bookmarks & History, defect, P1)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 3.6a1
People
(Reporter: jmjjeffery, Assigned: mak)
References
Details
(Keywords: dataloss, regression, verified1.9.1)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
Starting with the build on 12/10/2008 trunk nightly opening the Bookmarks Library, existing bookmarks with 'tags' no longer show / and cannot be edited in the lower right-pane. 1. Open the library 2. Select a bookmark with a 'tag' 3. note that in the lower right-pane in the 'tags drop list' there are no tags showing, and therefore cannot remove the tag. It was noted on IRC : i think the issue happens after you select folders/separators in the library and then go to a tagged item
Assignee | ||
Comment 1•16 years ago
|
||
i was seeing this, but after some time i did not see it anymore... so it' not a continue issue but something that happens. We for sure need some good STR, i was thinking to a regression from bug 461855 but if so, it should be visible in previous nightlies from 08 Dec. on
Assignee | ||
Comment 2•16 years ago
|
||
did you lose any tag or they simply don't show in the dialog (since that's what i was seeing)?
Flags: blocking-firefox3.1?
Target Milestone: --- → Firefox 3.1
Assignee | ||
Comment 3•16 years ago
|
||
oh and sometimes i was seeing graphic garbage in the field (part of the tag name)
Reporter | ||
Comment 4•16 years ago
|
||
reply to comment #2, no tags were not lost per se` , just not visible in the lower right-pane. Maybe the dataloss keyword is too strong... I was wrong, today's nightly is OK using buildset: http://hg.mozilla.org/mozilla-central/rev/29f1fa84f8fd I believe its broken in changeset: http://hg.mozilla.org/mozilla-central/rev/9952fee851da Retesting with latest hourly..
Reporter | ||
Comment 5•16 years ago
|
||
Yes, confirmed, broken in changeset: http://hg.mozilla.org/mozilla-central/rev/9952fee851da
Assignee | ||
Comment 6•16 years ago
|
||
i suspect is instead http://hg.mozilla.org/mozilla-central/rev/89a175c70c25 pushed at the same time, taggging service change from bug 463513
Blocks: 463513
Assignee | ||
Comment 7•16 years ago
|
||
i can confirm removing tagging service changes fixes the issue, so this is a regression to be fixed before next nightly.
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•16 years ago
|
||
we should go back to the folder node, that's because RESULTS_AS_TAG_QUERY actually does not return any itemId (queries are built on-the-fly) so we can't do child.itemId, we should instead use getConcreteItemId, but since PlacesUtils is not included (and i don't think we want to import it only for this) it's better going back for now) it's a pity our tests did not get this, i'm looking if i can add a test for previously existing tags before asking a review.
Assignee | ||
Comment 9•16 years ago
|
||
ok this comes with a unit test, i've done some cleanup in the test while there.
Attachment #352318 -
Attachment is obsolete: true
Attachment #352332 -
Flags: review?(dietrich)
Assignee | ||
Updated•16 years ago
|
Flags: in-testsuite?
OS: Windows Vista → All
Hardware: PC → All
Comment 10•16 years ago
|
||
Comment on attachment 352332 [details] [diff] [review] patch v1.1 r=me, thanks!
Attachment #352332 -
Flags: review?(dietrich) → review+
Updated•16 years ago
|
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Updated•16 years ago
|
Priority: -- → P1
Assignee | ||
Comment 11•16 years ago
|
||
pushed to trunk: http://hg.mozilla.org/mozilla-central/rev/523bdc086002
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•16 years ago
|
Flags: in-testsuite? → in-testsuite+
Comment 12•16 years ago
|
||
Had to back this out due to persistent orange. Please try again when the tree is green.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 13•16 years ago
|
||
note: this is not the cause of the orange and was pushed on green tree, unlucky the patch that caused orange was pushed a few minutes before this.
Assignee | ||
Comment 14•16 years ago
|
||
pushed again on trunk: http://hg.mozilla.org/mozilla-central/rev/2c82db5dff7a
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 15•16 years ago
|
||
Verified fixed using changeset: http://hg.mozilla.org/mozilla-central/rev/6f34b3d7748d Hourly build: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20081211 Minefield/3.2a1pre Firefox/3.0.4 ID:20081211084445
Status: RESOLVED → VERIFIED
Comment 16•16 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/bc7ef61db0cd
Keywords: fixed1.9.1
Target Milestone: Firefox 3.1 → Firefox 3.2a1
Comment 17•16 years ago
|
||
verified FIXED on Shiretoko: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3 ID:20090305133223
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•