With the current trunk, under KDE (Kubuntu 8.04, KDE 3.5.10), Firefox crashes at startup: Program ./firefox-bin (pid = 17936) received signal 11. Stack: createQApp+0x00000CFA [/usr/lib/gtk-2.0/2.10.0/engines/libqtengine.so +0x0001A27A] theme_init+0x0000001F [/usr/lib/gtk-2.0/2.10.0/engines/libqtengine.so +0x0000753F] UNKNOWN [/usr/lib/libgtk-x11-2.0.so.0 +0x00215C76] g_type_module_use+0x00000088 [/usr/lib/libgobject-2.0.so.0 +0x0002C608] gtk_theme_engine_get+0x00000049 [/usr/lib/libgtk-x11-2.0.so.0 +0x00215AA9] UNKNOWN [/usr/lib/libgtk-x11-2.0.so.0 +0x00193A0E] UNKNOWN [/usr/lib/libgtk-x11-2.0.so.0 +0x00195D1E] UNKNOWN [/usr/lib/libgtk-x11-2.0.so.0 +0x0019691B] UNKNOWN [/usr/lib/libgtk-x11-2.0.so.0 +0x00196DB2] UNKNOWN [/usr/lib/libgtk-x11-2.0.so.0 +0x00196F3E] UNKNOWN [/usr/lib/libgtk-x11-2.0.so.0 +0x00196B69] UNKNOWN [/usr/lib/libgtk-x11-2.0.so.0 +0x00196DB2] UNKNOWN [/usr/lib/libgtk-x11-2.0.so.0 +0x00196F3E] gtk_rc_reparse_all_for_settings+0x00000104 [/usr/lib/libgtk-x11-2.0.so.0 +0x00197324] gtk_settings_get_for_screen+0x000000B4 [/usr/lib/libgtk-x11-2.0.so.0 +0x001B2C34] XRE_main+0x00001245 [./libxul.so +0x000256D9] UNKNOWN [./firefox-bin +0x00001932] __libc_start_main+0x000000E0 [/lib/tls/i686/cmov/libc.so.6 +0x00016450] It appears in fact it crashes since the landing of the patch of the Bug 460926 ( http://hg.mozilla.org/mozilla-central/rev/71c3a9d14712 ). I compiled Firefox at the previous revision : all is ok. And with this patch, Firefox crashes. Perhaps we call gtk_settings_get_for_screen to early or something like that ?

FWIW, it seems bug 460926 only landed on trunk and not branch... this means this bug is not blocking 1.9.1 until/unless that bug is approved for the branch.

Apparently, it doesn't crash with KDE 4.1.2. However KDE 4 is not used everywhere (it is so young :-)) and so this bug really needs to be fix.

Bug 469496 has more info, including a better stack trace.

I see this crash too on Kubuntu 8.04 x86-64. A quick workaround is to change System Settings in KDE: under Look&Feel / Appearance / GTK Styles and Fonts: change "GTK Styles" to "Use another style" and select anything except "Qt" in the dropdown. I also found bug 460926 to be the culprit: http://hg.mozilla.org/mozilla-central/rev/71c3a9d14712 If I remove the entire "#ifdef MOZ_ACCESSIBILITY_ATK" block there the crash does not occur.

This fixes the crash... Ginn, please verify it doesn't regress bug 460926.

Comment on attachment 352869 [details] [diff] [review] Patch rev. 1 Yes, I think it regresses Bug 460926. So we stuck here, if we don't call gdk_display_manager_set_default_display() before gtk_settings_get_for_screen(), it crashes at gdk_x11_get_default_xdisplay() on KDE. if we call gdk_display_manager_set_default_display() before gtk_settings_get_for_screen(), the settings are already applied before we modify it.

Maybe we should back out and reopen bug 460926 while we think of a different solution then?

OK. Can I do it for me? I need to go now. Thanks! Or I'll do it tomorrow.

(In reply to comment #9) > OK. > > Can I do it for me? I need to go now. Thanks! ^^ you. > > Or I'll do it tomorrow.

Pushed backout: http://hg.mozilla.org/mozilla-central/rev/9bc6733d81cc