See bug 461680 comment 5: > You shouldn't be using id in xbl. Two of these in a document would mean two > elements with that id. Usually, we use anonid for this, or a class for css > purposes. Yeah, the other Neil caught this. It actually seems to work now (at least, doc.getElementById doesn't pick any of them up, which was his concern), but I agreed we should change them anyway. I'll do this in a followup patch, instead of cluttering this one. Neil also put up an example patch in attachment 351361 [details] [diff] [review].

Switches id= to class=. I started to go with anonid, but that makes the CSS slightly uglier. I also realized this might all change again when switching the controls to <buttons>, but oh well. Already finished the patch done. :)

Comment on attachment 352445 [details] [diff] [review] Patch v.1 You may want to fix up the missing space on the .muteButton lines while you're at it.

Pushed http://hg.mozilla.org/mozilla-central/rev/8e972df8be8e

Can this alo be pushed to 1.9.1/FF3.1 as otherwise themers would have to use both # and . to style the videocontrols in their theme, if they want to keep the theme compatible between 3.1 and 3.1...

The intention is to land this on 1.9.1, which is why I requested approval1.9.1 on the patch! :-)

Comment on attachment 352445 [details] [diff] [review] Patch v.1 a191=beltzner, though I think this should probably be a blocker ...

Pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/2101089fcb6c