Closed
Bug 469499
Opened 16 years ago
Closed 13 years ago
kill macbrowser ifdefs
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla7
People
(Reporter: kairo, Assigned: emorley)
References
()
Details
(Whiteboard: fixed-in-cedar)
Attachments
(1 file)
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
I just ran across some non-macbrowser-defined code in xpfe/components (which we probably should get rid of completely), and decided to see if we still have some of that code left anywhere. The places are scarce, and I really think we should get rid of those. If Camino moves on to being based on mozilla-central one time, they really should use a stock XULRunner as their base, if possible.
Assignee | ||
Comment 1•14 years ago
|
||
Removes MOZ_MACBROWSER, since it's no longer defined:
http://mxr.mozilla.org/mozilla-central/search?string=MOZ_MACBROWSER
The now removed lines in mozSpellCheckerFactory.cpp were the last users of osxspell, so takes that out too:
http://mxr.mozilla.org/mozilla-central/search?string=OSXSpell
Assignee | ||
Comment 2•14 years ago
|
||
Updated•13 years ago
|
Attachment #535970 -
Flags: review?(benjamin) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Version: unspecified → Trunk
Comment 3•13 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla7
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Aaaaah, what please is the reason for completely removing OSXSpell? I use this constantly for my own builds and I love it. And a few bugs I've opened are based on OSXSpell.
Assignee | ||
Comment 6•13 years ago
|
||
Removing MOZ_MACBROWSER caused it to become dead code per comment 1.
You presumably already had to patch your local build to enable it, so can't you just export the hg revert of this patch and add that to your mq?
(In reply to comment #6)
> You presumably already had to patch your local build to enable it, so can't
> you just export the hg revert of this patch and add that to your mq?
Yes, I had to revert Bug 422760 to enable it. But OK, I also will add this patch to my revert list. Thanks for the hint with mq!
Updated•7 years ago
|
Product: Core → Firefox Build System
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•