Closed
Bug 469581
Opened 16 years ago
Closed 16 years ago
|make *test*| doesn't accept arguments, like --leak-threshold
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b4])
Attachments
(2 files)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
kairo
:
review+
|
Details | Diff | Splinter Review |
This is the first time I look into bug 417516: first impression is that it may be good for beginners or as self-documentation, but, as it is, it can not be used instead of the commandline (esp. for buildbot). Maybe, when it was done some months ago, focus was not yet on leaks, but, now, it needs to be enhanced (or dropped ?).
Assignee | ||
Comment 3•16 years ago
|
||
Per comment 2, plus a little code merging. While there, fix bug 468913 comment 18 too.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #365881 -
Flags: review?(ted.mielczarek)
Updated•16 years ago
|
Attachment #365881 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 4•16 years ago
|
||
Comment on attachment 365881 [details] [diff] [review] (Av1) Support an |EXTRA_TEST_ARGS| variable [Checkin: See comment 4 & 5] http://hg.mozilla.org/mozilla-central/rev/1c35af83002a (In reply to comment #3) > While there, fix bug 468913 comment 18 too. Without this part, which was fixed in the meantime.
Attachment #365881 -
Attachment description: (Av1) Support an |EXTRA_TEST_ARGS| variable → (Av1) Support an |EXTRA_TEST_ARGS| variable
[Checkin: See comment 4]
Assignee | ||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Assignee | ||
Comment 5•16 years ago
|
||
Comment on attachment 365881 [details] [diff] [review] (Av1) Support an |EXTRA_TEST_ARGS| variable [Checkin: See comment 4 & 5] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c20da57a863f
Attachment #365881 -
Attachment description: (Av1) Support an |EXTRA_TEST_ARGS| variable
[Checkin: See comment 4] → (Av1) Support an |EXTRA_TEST_ARGS| variable
[Checkin: See comment 4 & 5]
Assignee | ||
Updated•16 years ago
|
Assignee | ||
Comment 6•16 years ago
|
||
(Looks like I had forgotten the c-c part.)
Attachment #369078 -
Flags: review?(kairo)
![]() |
||
Comment 7•16 years ago
|
||
Comment on attachment 369078 [details] [diff] [review] (Bv1-CC) Keep SeaMonkey |mochitest-browser-chrome| in sync' [Checkin: Comment 9] Ugh, I just worked hard to get TEST_PATH supported on SeaMonkey in bug 484386 and now this comes along...
Assignee | ||
Comment 8•16 years ago
|
||
Comment on attachment 369078 [details] [diff] [review] (Bv1-CC) Keep SeaMonkey |mochitest-browser-chrome| in sync' [Checkin: Comment 9] (In reply to comment #7) Is my patch breaking things for you ? Works-for-me example: clear && env NO_FAIL_ON_TEST_ERRORS=1 TEST_PATH=toolkit/content/tests/browser/browser_bug471962.js make -C objdir mochitest-browser-chrome
![]() |
||
Updated•16 years ago
|
Attachment #369078 -
Flags: review?(kairo) → review+
Assignee | ||
Comment 9•16 years ago
|
||
Comment on attachment 369078 [details] [diff] [review] (Bv1-CC) Keep SeaMonkey |mochitest-browser-chrome| in sync' [Checkin: Comment 9] http://hg.mozilla.org/comm-central/rev/e79e68147a0f
Attachment #369078 -
Attachment description: (Bv1-CC) Keep SeaMonkey |mochitest-browser-chrome| in sync' → (Bv1-CC) Keep SeaMonkey |mochitest-browser-chrome| in sync'
[Checkin: Comment 9]
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•