Serge Gautherie (:sgautherie) Assignee
	Description • 16 years ago

This is the first time I look into bug 417516:
first impression is that it may be good for beginners or as self-documentation,
but, as it is, it can not be used instead of the commandline (esp. for buildbot).

Maybe, when it was done some months ago, focus was not yet on leaks,
but, now, it needs to be enhanced (or dropped ?).

	Serge Gautherie (:sgautherie) Assignee
	Comment 1 • 16 years ago

Enhancement -> Normal, now that we need to do bug 479225.

	(not currently active) Ted Mielczarek
	Comment 2 • 16 years ago

Could just add an EXTRA_ARGS option or something.

	Serge Gautherie (:sgautherie) Assignee
	Comment 3 • 16 years ago

Per comment 2,
plus a little code merging.

While there, fix bug 468913 comment 18 too.

	Serge Gautherie (:sgautherie) Assignee
	Comment 4 • 16 years ago

Comment on attachment 365881 [details] [diff] [review]
(Av1) Support an |EXTRA_TEST_ARGS| variable
[Checkin: See comment 4 & 5]


http://hg.mozilla.org/mozilla-central/rev/1c35af83002a

(In reply to comment #3)
> While there, fix bug 468913 comment 18 too.

Without this part, which was fixed in the meantime.

	Serge Gautherie (:sgautherie) Assignee
	Comment 5 • 16 years ago

Comment on attachment 365881 [details] [diff] [review]
(Av1) Support an |EXTRA_TEST_ARGS| variable
[Checkin: See comment 4 & 5]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c20da57a863f

	Serge Gautherie (:sgautherie) Assignee
	Comment 6 • 16 years ago

(Looks like I had forgotten the c-c part.)

	Robert Kaiser
	Comment 7 • 16 years ago

Comment on attachment 369078 [details] [diff] [review]
(Bv1-CC) Keep SeaMonkey |mochitest-browser-chrome| in sync'
[Checkin: Comment 9]

Ugh, I just worked hard to get TEST_PATH supported on SeaMonkey in bug 484386 and now this comes along...

	Serge Gautherie (:sgautherie) Assignee
	Comment 8 • 16 years ago

Comment on attachment 369078 [details] [diff] [review]
(Bv1-CC) Keep SeaMonkey |mochitest-browser-chrome| in sync'
[Checkin: Comment 9]


(In reply to comment #7)

Is my patch breaking things for you ?

Works-for-me example:
clear && env NO_FAIL_ON_TEST_ERRORS=1 TEST_PATH=toolkit/content/tests/browser/browser_bug471962.js make -C objdir mochitest-browser-chrome

	Serge Gautherie (:sgautherie) Assignee
	Comment 9 • 16 years ago

Comment on attachment 369078 [details] [diff] [review]
(Bv1-CC) Keep SeaMonkey |mochitest-browser-chrome| in sync'
[Checkin: Comment 9]


http://hg.mozilla.org/comm-central/rev/e79e68147a0f