Closed
Bug 469639
Opened 16 years ago
Closed 16 years ago
failed to build firefox trunk on OpenSolaris
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla3.6a1
People
(Reporter: eagle.lu, Assigned: eagle.lu)
References
Details
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
roc
:
superreview+
|
Details | Diff | Splinter Review |
When configure firefox trunk on OpenSolaris, I got following error:
checking MOZ_DBUS_GLIB_CFLAGS... -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
checking MOZ_DBUS_GLIB_LIBS... -ldbus-glib-1 -ldbus-1 -lgobject-2.0 -lglib-2.0
/export/home/brian/moz-ws/community3/1215/mozilla-central/configure: test: unknown operator ==
*** Fix above errors and then restart with "make -f client.mk build"
The root cause is that /bin/sh is not bash on Solaris
Attachment #353000 -
Flags: review?(jst)
Assignee: nobody → brian.lu
Attachment #353001 -
Flags: review?(chris.double)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 353001 [details] [diff] [review]
define HAVE_ALLOCA_H on Solaris
Please add to README_MOZILLA the number of the bug this patch is for. Thanks!
Attachment #353001 -
Flags: review?(chris.double) → review+
Summary: failed to configure firefox trunk on OpenSolaris → failed to build firefox trunk on OpenSolaris
Attachment #353003 -
Flags: superreview?(roc)
Attachment #353003 -
Flags: superreview?(roc) → superreview+
|
||
Updated•16 years ago
|
Attachment #353000 -
Flags: review?(jst)
Attachment #353000 -
Flags: review?(wtc)
|
||
Comment 4•16 years ago
|
||
Comment on attachment 353000 [details] [diff] [review]
Use "-eq" instead of "=="
r=wtc. But I'd like to suggest that you use = (just one equal sign)
instead of -eq. I'm not a shell programming expert, so I just looked
at the existing usage of "test" in mozilla/configure.in and
mozilla/nsprpub/configure.in. I found that for string comparision,
= is always used. So it'd be nice to be consistent with current usage.
Attachment #353000 -
Flags: review?(wtc) → review+
Attachment #353338 -
Flags: superreview?(benjamin)
|
||
Updated•16 years ago
|
Attachment #353338 -
Flags: superreview?(benjamin) → superreview+
Keywords: checkin-needed
|
||
Updated•16 years ago
|
Attachment #353001 -
Attachment is obsolete: true
|
|
||
Updated•16 years ago
|
Attachment #353000 -
Attachment is obsolete: true
|
|
||
Updated•16 years ago
|
Attachment #353338 -
Attachment description: replace '-eq' with '=' → replace '-eq' with '=' [See bug 468463]
Attachment #353338 -
Attachment is obsolete: true
|
|
||
Comment 6•16 years ago
|
||
Comment on attachment 353003 [details] [diff] [review]
adding bug number in README_MOZILLA
[Checkin: Comment 6]
http://hg.mozilla.org/mozilla-central/rev/6af107f076c7
Attachment #353003 -
Attachment description: adding bug number in README_MOZILLA → adding bug number in README_MOZILLA
[Checkin: Comment 6]
|
|
||
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Version: unspecified → Trunk
|
||
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
|
||
Updated•6 years ago
|
Target Milestone: Firefox 3.6a1 → mozilla3.6a1
You need to log in
before you can comment on or make changes to this bug.
Description
•