Jesse Ruderman Reporter
	Description • 16 years ago

###!!! ASSERTION: Whoever was caching this font group should have called UpdateFontList on it: '!mUserFontSet || mCurrGeneration == GetGeneration()', file ../../../dist/include/thebes/gfxAtsuiFonts.h, line 142

	Karl Tomlinson (:karlt) Assignee
	Comment 1 • 16 years ago

I'm thinking that gfxUserFontSet::mGeneration does not need to be incremented after LookupLocalFont.  AFAICT there's nothing asynchronous here (ignoring bug 465463, that is), so there's no generation used before the LookupLocalFont.

	John Daggett (:jtd)
	Comment 3 • 16 years ago

Comment on attachment 354086 [details] [diff] [review]
don't increment generation after LookupLocalFont

Because local fonts are created when looked up, their creation doesn't affect the lookup behavior of a font group, so there's no need to bump the generation number.

	Karl Tomlinson (:karlt) Assignee
	Comment 4 • 16 years ago

Fixed on m-c:
http://hg.mozilla.org/mozilla-central/rev/a828ae6e92f4

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 5 • 16 years ago

Comment on attachment 354086 [details] [diff] [review]
don't increment generation after LookupLocalFont

a191=beltzner

	Karl Tomlinson (:karlt) Assignee
	Comment 6 • 16 years ago

Fixed on 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7dbcda0d0fb8

	Aakash Desai [:aakashd]
	Comment 7 • 15 years ago

verified FIXED on debug builds:


Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090608 Shiretoko/3.5pre ID:20090608122057

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090608 Minefield/3.6a1pre ID:20090608122028