Closed
Bug 470455
Opened 16 years ago
Closed 16 years ago
test_database_sync_embed_visits.js leaks
Categories
(Toolkit :: Places, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: sgautherie, Assigned: mak)
References
Details
(Keywords: fixed1.9.1, memory-leak)
Attachments
(1 file)
|
(deleted),
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081219 Minefield/3.2a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/9410ad10c6f7)
This newly added test has the same(-looking) leak as bug 469062 had...
|
Reporter | |
Updated•16 years ago
|
Summary: test_database_sync_embed_visits.js leaks now → test_database_sync_embed_visits.js leaks
|
Assignee | |
Comment 1•16 years ago
|
||
yes, should be fixed with bug 469972.
|
|
Assignee | |
Comment 2•16 years ago
|
||
it's not but that's my fault, apparently i did not attach latest version of the test, dunno why, sorry.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•16 years ago
|
||
remove a dump i had added while building the test, and fix finish
Attachment #353932 -
Flags: review?(sdwilsh)
|
|
Assignee | |
Updated•16 years ago
|
Target Milestone: --- → mozilla1.9.1
|
|
Reporter | |
Comment 4•16 years ago
|
||
(In reply to comment #2)
I confirm that:
*Bug 469972 "v1.0" patch did not fix this.
*This is the only /toolkit/components/places/tests/sync/ test which calls do_test_finished() directly.
|
|
Assignee | |
Comment 5•16 years ago
|
||
(In reply to comment #4)
> (In reply to comment #2)
>
> I confirm that:
> *Bug 469972 "v1.0" patch did not fix this.
> *This is the only /toolkit/components/places/tests/sync/ test which calls
> do_test_finished() directly.
both patches are needed to fix this
|
||
Comment 6•16 years ago
|
||
Comment on attachment 353932 [details] [diff] [review]
patch v1
r=sdwilsh
Attachment #353932 -
Flags: review?(sdwilsh) → review+
|
|
Reporter | |
Comment 7•16 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081221 SeaMonkey/2.0a3pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/b839ff0630c6
+http://hg.mozilla.org/comm-central/rev/2a4c4c1f0feb + bug 469606 patch)
Confirming with SeaMonkey.
|
|
Assignee | |
Comment 8•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1 → mozilla1.9.2a1
|
|
Reporter | |
Comment 9•16 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081222 SeaMonkey/2.0a3pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/31dbaf4ca0c4
+http://hg.mozilla.org/comm-central/rev/113540504a46 + bug 469606 patch)
V.Fixed
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
|
|
Assignee | |
Comment 10•16 years ago
|
||
Keywords: fixed1.9.1
|
|
Reporter | |
Updated•16 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•