Closed
Bug 470916
Opened 16 years ago
Closed 16 years ago
ASSERTION: root view manager's default background isn't opaque on print preview
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: martijn.martijn, Assigned: zwol)
References
Details
(Keywords: assertion)
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
I get this assertion on print preview when I have the option "Print Background (Colors & Images)" checked in Page Setup:
###!!! ASSERTION: root view manager's default background isn't opaque: 'needTran
sparency || NS_GET_A(backgroundColor) == 255', file c:/mozilla-build-1.3/src/lay
out/base/nsPresShell.cpp, line 5397
Hg blame leads to the patch in bug 467459, so I guess that bug is responsible for this assertion.
|
Assignee | |
Comment 1•16 years ago
|
||
Here's a patch, which takes a "final" opaque color from the pres context if necessary. I originally coded bug 467459 that way but roc didn't think it would be needed -- so maybe there's a better way to do this, but I don't know what it is. With the patch I do not get the assertion.
Assignee: nobody → zweinberg
Status: NEW → ASSIGNED
Attachment #356764 -
Flags: superreview?(roc)
Attachment #356764 -
Flags: review?(roc)
|
|
Assignee | |
Comment 2•16 years ago
|
||
nom'ing for 1.9.1 - low risk (IMO) & eliminates an assertion.
Flags: blocking1.9.1?
How does the root view manager get a non-opaque default background color in this case?
Flags: blocking1.9.1? → wanted1.9.1+
|
|
Assignee | |
Comment 4•16 years ago
|
||
This assertion was removed by bug 474201.
|
||
Updated•16 years ago
|
Attachment #356764 -
Flags: superreview?(roc)
Attachment #356764 -
Flags: review?(roc)
You need to log in
before you can comment on or make changes to this bug.
Description
•