Closed
Bug 47138
Opened 24 years ago
Closed 24 years ago
[fix in hand]Some invalid units are not resulting in dropped declarations
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Tracking
()
VERIFIED
FIXED
M18
People
(Reporter: ian, Assigned: pierre)
References
()
Details
(Keywords: css1, testcase, Whiteboard: [fix in hand][nsbeta3+] hit during nsbeta2 standards compliance testing)
Attachments
(2 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Well, looks like the nsbeta2 testing is bringing out all the skeletons from our
collective cupboard... ;-)
Some properties, including margin, padding and border, and probably the various
border shorthands, are not getting dropped if they include invalid units.
For example, the following:
DIV { border: red solid 3nm; }
...is resulting in a medium sized red border.
This is invalid per the CSS1 forward compatability parsing rules.
TO REPRODUCE:
View the testcase or visit
http://www.webstandards.org/css/macie/errorhandlingdemo1.html
...which is a high profile testcase by the Web Standards Project.
EXPECTED RESULTS:
*Any* declaration containing an invalid unit specifier or any other sort of
syntax error should be dropped completely. Note: declaration = property/
value pair, not the entire rule... ;-)
ACTUAL RESULTS:
We seem to be silently dropping lengths with invalid units, and not dropping
the rest of the rule. However, it seems to depend on where in the declaration
the error occurs -- if it is at the beginning, then we ignore all of the
numbers, for instance. See the testcase for details.
TESTED ON:
Windows 2000 commercial build 6.0.17.2000072920.
Nominating for nsbeta3. This is a standards compliance error which is caught by
a testcase on a high profile test suite.
Reporter | ||
Updated•24 years ago
|
QA Contact: chrisd → py8ieh=bugzilla
Whiteboard: hit during nsbeta2 standards compliance testing
Reporter | ||
Comment 1•24 years ago
|
||
Comment 2•24 years ago
|
||
Easy fix per pierre; [nsbeta3+].
Whiteboard: hit during nsbeta2 standards compliance testing → [nsbeta3+] hit during nsbeta2 standards compliance testing
Assignee | ||
Comment 3•24 years ago
|
||
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Summary: Some invalid units are not resulting in dropped declarations → [fix in hand]Some invalid units are not resulting in dropped declarations
Whiteboard: [nsbeta3+] hit during nsbeta2 standards compliance testing → [fix in hand][nsbeta3+] hit during nsbeta2 standards compliance testing
Target Milestone: --- → M18
Assignee | ||
Comment 4•24 years ago
|
||
Fix checked in nsCSSParser.cpp
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•24 years ago
|
||
VERIFIED FIXED on Windows 2000 and Linux Commercial Bits 2000090808.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•