Closed
Bug 471776
Opened 16 years ago
Closed 16 years ago
Textboxes with emptytext shouldn't enable undo for display and deletion of empty text
Categories
(Toolkit :: XUL Widgets, defect)
Toolkit
XUL Widgets
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: graememcc, Assigned: graememcc)
References
Details
(Keywords: verified1.9.1)
Attachments
(2 files)
|
(deleted),
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Spinning this off from bug 471319...
That bug found a problem in the editor code with undo/redo. However, part of the problem is that undo shouldn't be enabled in the first place when there hasn't been a user edit.
|
Assignee | |
Comment 1•16 years ago
|
||
When clearing empty text, try and clean up after ourselves.
Attachment #355036 -
Flags: review?(gavin.sharp)
|
||
Updated•16 years ago
|
Whiteboard: [has patch][needs review gavin]
|
|
||
Comment 3•16 years ago
|
||
Gavin, do you have time to review this patch?
Assignee: nobody → graememcc_firefox
Status: NEW → ASSIGNED
|
|
||
Updated•16 years ago
|
Flags: wanted1.9.1?
Flags: in-testsuite?
|
|
Assignee | |
Updated•16 years ago
|
Attachment #355036 -
Flags: review?(gavin.sharp) → review?(enndeakin)
|
|
Assignee | |
Comment 4•16 years ago
|
||
Comment on attachment 355036 [details] [diff] [review]
Patch
Neil, are you able to review this change at all?
|
|
||
Updated•16 years ago
|
Whiteboard: [has patch][needs review gavin] → [has patch][needs review enndeakin]
|
||
Updated•16 years ago
|
Attachment #355036 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Comment 5•16 years ago
|
||
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [has patch][needs review enndeakin]
|
||
Comment 6•16 years ago
|
||
Comment on attachment 361632 [details] [diff] [review]
hg export for checkin
[Checkin: Comment 6]
http://hg.mozilla.org/mozilla-central/rev/787fde278f78
Attachment #361632 -
Attachment description: hg export for checkin → hg export for checkin
[Checkin: Comment 6]
|
|
||
Updated•16 years ago
|
Blocks: 471319
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite? → in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
|
Assignee | |
Updated•16 years ago
|
Attachment #361632 -
Flags: approval1.9.1?
|
|
||
Comment 7•16 years ago
|
||
Verified fixed with builds on OS X and Windows:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090216 Minefield/3.2a1pre ID:20090216020430
|
|
||
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
|
||
Comment 8•16 years ago
|
||
Comment on attachment 361632 [details] [diff] [review]
hg export for checkin
[Checkin: Comment 6]
a191=beltzner
Attachment #361632 -
Flags: approval1.9.1? → approval1.9.1+
|
||
Updated•16 years ago
|
Keywords: checkin-needed
|
|
||
Comment 9•16 years ago
|
||
Keywords: checkin-needed → fixed1.9.1
|
|
||
Comment 10•16 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090404 Shiretoko/3.5b4pre ID:20090404035045 and on Windows.
What about the location bar? It looks somewhat inconsistent in its behavior. Opening a new tab, clicking away, and opening its context menu still shows the undo entry enabled. I can go back several steps and at some point urls are shown which were entered in other tabs. Do we share the undo stack between tabs? I think that's a bug. I wanted to ask before I file a new bug on that issue.
Flags: wanted1.9.1?
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•