Closed
Bug 472988
Opened 16 years ago
Closed 16 years ago
thread pane loses saved search's folder location column when switching tabs
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b2
People
(Reporter: wsmwk, Assigned: Bienvenu)
References
Details
Attachments
(1 file)
(deleted),
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081230 Shredder/3.0b2pre
thread pane loses saved search's location column when switching tabs, if last opened tab is a real folder
1. tab 1 is a saved search against multiple folders - it has a location column
2. right click any "real" folder and open in new tab
3. click back to tab 1
actual results: location column is gone for the saved search in tab 1
Workaround is open another saved search and the column comes back, but the behavior reflects poorly on tab UI.
Reverse the order and no problem - the thread pane columns that stick are those of the last opened tab.
Perhaps could be fixed by bug 259609, which I had marked wanted-thunderbird3? (because it seems simple, and useful). But the solution for the bug could be far simpler - just force location column every time one changes to a saved search tab. (xref bug 374551, which is about manually *removing* location column)
Flags: wanted-thunderbird3?
Reporter | ||
Comment 1•16 years ago
|
||
bienvenu, do you think bug 259609 would really be required to accomplish this, and who might be able to handle this in TB3 time frame?
Assignee | ||
Comment 2•16 years ago
|
||
no, I don't think bug 259609 would be required at all - we just need to make the tab switching code a little smarter. If asuth hasn't fixed this already in one of his tab patches, I can fix this.
Reporter | ||
Comment 3•16 years ago
|
||
(In reply to comment #2)
> If asuth hasn't fixed this already in one of his tab patches, I can fix this.
asuth, FYI this wouldn't be so bad, except leaving and returning the saved search folder (the workaround) doesn't remember the last accessed message, which is painful
Summary: thread pane loses saved search's location column when switching tab s → thread pane loses saved search's folder location column when switching tabs
Comment 4•16 years ago
|
||
Yes, I am planning to address this as part of the gloda-search changes. I'm going to try and clean up this whole area a bit more. However, this is probably a week out; if bienvenu would like to provide a quick patch for b2, that's also fine.
Assignee: nobody → bugmail
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•16 years ago
|
||
I'll have a quick look
Assignee | ||
Comment 6•16 years ago
|
||
Andrew, do you have time to look at this for b2? Otherwise, I can ping someone else for review. Basically, I moved some column updating calls into a shared method.
Assignee: bugmail → bienvenu
Attachment #362733 -
Flags: review?
Assignee | ||
Updated•16 years ago
|
Attachment #362733 -
Flags: review? → review?(bugmail)
Updated•16 years ago
|
Attachment #362733 -
Flags: review?(bugmail) → review+
Comment 7•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Flags: wanted-thunderbird3?
Target Milestone: --- → Thunderbird 3.0b2
Updated•16 years ago
|
OS: Windows XP → All
Hardware: x86 → All
You need to log in
before you can comment on or make changes to this bug.
Description
•