Closed
Bug 473001
Opened 16 years ago
Closed 16 years ago
Re-add support to reorder newsgroups using drag drop
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
VERIFIED
FIXED
Thunderbird 3.0b2
People
(Reporter: rain1, Assigned: iannbugzilla)
References
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
iannbugzilla
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Bug 150274 added support to reorder newsgroups through drag and drop. With the js folder pane, support for this was lost. This bug is to re-add support for this.
Flags: wanted-thunderbird3?
Flags: in-litmus?
|
||
Updated•16 years ago
|
Blocks: 414038
Flags: wanted-thunderbird3? → wanted-thunderbird3+
Keywords: regression
Target Milestone: --- → Thunderbird 3.0rc1
This patch:
* Adds text/x-moz-newsfolder to drag and drop types used.
* Adds support re-organising newsgroups via drag and drop.
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #360013 -
Flags: review?(mkmelin+mozilla)
Patch from bug 465015 needs to be applied for this to work.
Depends on: 465015
Attachment #360013 -
Flags: review?(mkmelin+mozilla)
Changes since v0.1:
* Unbitrotted after push of patch on bug 465015.
* When dropping multiple newsgroups, selected folders stay in the same order.
Attachment #360013 -
Attachment is obsolete: true
Attachment #360028 -
Flags: review?(mkmelin+mozilla)
|
|
||
Updated•16 years ago
|
Attachment #360028 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 360028 [details] [diff] [review]
Add support for newsgroups to drag and drop patch v0.1a
Looks good to me, works fine too:) r=mkmelin
|
|
||
Updated•16 years ago
|
Target Milestone: Thunderbird 3.0rc1 → Thunderbird 3.0b2
Attachment #360028 -
Flags: superreview?(neil)
|
||
Comment 5•16 years ago
|
||
Comment on attachment 360028 [details] [diff] [review]
Add support for newsgroups to drag and drop patch v0.1a
>+ // Don't allow dragging newsgroup to before/after itself.
>+ let row = aRow + aOrientation;
This is actually checking that you're not dragging to just before the item after (or just after the item before). I take it that something else prevents you from dropping before/after itself?
Attachment #360028 -
Flags: superreview?(neil) → superreview+
Changes since v0.1a:
* Adds check for before/after item.
* Corrects comment for before the item after and after the item before.
Attachment #360028 -
Attachment is obsolete: true
Attachment #360812 -
Flags: superreview?(neil)
Attachment #360812 -
Flags: review+
|
|
||
Updated•16 years ago
|
Attachment #360812 -
Flags: superreview?(neil) → superreview+
Attachment #360812 -
Attachment description: Add support for newsgroups to drag and drop patch v0.1b → Add support for newsgroups to drag and drop patch v0.1b (Push: Comment 7)
Comment on attachment 360812 [details] [diff] [review]
Add support for newsgroups to drag and drop patch v0.1b (Push: Comment 7)
http://hg.mozilla.org/comm-central/rev/33ebcd9e22ba
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 8•16 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090208 Shredder/3.0b2pre ID:20090208025606 and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090208 Shredder/3.0b2pre
One more bug I noticed while verifying this fix is bug 477499.
Status: RESOLVED → VERIFIED
|
||
Comment 9•15 years ago
|
||
Added https://litmus.mozilla.org/show_test.cgi?id=9510 to BFT and FFT
Flags: in-litmus? → in-litmus+
You need to log in
before you can comment on or make changes to this bug.
Description
•