Closed
Bug 473430
Opened 16 years ago
Closed 12 years ago
Teach Treehydra's Zero-Nonzero ESP analysis to handle TRUTH_NOT_EXPR nodes
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: graydon, Assigned: graydon)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
This is necessary to handle many control patterns GCC generates (also standard ones users write such as if(!b) { ... })
Attachment #356795 -
Flags: review?(dmandelin)
|
||
Updated•16 years ago
|
Attachment #356795 -
Flags: review?(dmandelin) → review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 356795 [details] [diff] [review]
Handle the node.
Looks good, except please also add the final 'blame' argument to your calls to assignMapped and remove. That argument is supposed to be the GIMPLE instruction that caused the effect to happen, for use in error reports.
|
Assignee | |
Comment 2•16 years ago
|
||
Assignee: nobody → graydon
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Comment 3•16 years ago
|
||
I just realized that the evaluator function is a bit wrong because it was designed over concrete values but it needs to consider abstract values. I think the only way it goes wrong is that !TOP should be TOP, but currently it would evaluate to 0.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 4•12 years ago
|
||
Dehydra and treehydra are no longer maintained by Mozilla.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 12 years ago
Resolution: --- → WONTFIX
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•