Closed
Bug 473734
Opened 16 years ago
Closed 16 years ago
Switch matchOnlyTyped to restrict.typed "~" (default.behavior + 32)
Categories
(SeaMonkey :: Location Bar, defect)
SeaMonkey
Location Bar
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey2.0a3
People
(Reporter: kairo, Assigned: kairo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
We need to do the same as bug 463483 for SeaMonkey, meaning another adjustment to UI prefs as well.
Due to restrict.typed missing in our default prefs (bug 472603 will improve that situation in the future), we're currently failing unit tests that rely on this, originally reported as bug 472978 but I'll dupe it here as the work in this bug will fix them.
Assignee | ||
Comment 2•16 years ago
|
||
Here's the fix for this one, and now it really makes sense that those pref sync functions hand over aField ;-)
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #357124 -
Flags: superreview?(neil)
Attachment #357124 -
Flags: review?(neil)
Comment 4•16 years ago
|
||
Comment on attachment 357124 [details] [diff] [review]
switch to new pref(s)
>-pref("browser.urlbar.matchOnlyTyped", false);
Is there a bug for migrating to places prefs?
>+ document.getElementById("matchOnlyURLs").disabled = matchDisabled;
> document.getElementById("matchOnlyTyped").disabled = matchDisabled;
IMHO Typed belongs before URLs
>+ // Return the right bit based on the id of "aField"
Hmm, might be better to have
const kBehaviourBit = {
matchOnlyURLs: 16,
matchOnlyTyped: 32
};
then use kBehaviourBit[aField.id]
Assignee | ||
Comment 5•16 years ago
|
||
(In reply to comment #4)
> (From update of attachment 357124 [details] [diff] [review])
> >-pref("browser.urlbar.matchOnlyTyped", false);
> Is there a bug for migrating to places prefs?
You mean on profile migration? I don't know of any...
> >+ document.getElementById("matchOnlyURLs").disabled = matchDisabled;
> > document.getElementById("matchOnlyTyped").disabled = matchDisabled;
> IMHO Typed belongs before URLs
Easy to do :)
> >+ // Return the right bit based on the id of "aField"
> Hmm, might be better to have
> const kBehaviourBit = {
> matchOnlyURLs: 16,
> matchOnlyTyped: 32
> };
> then use kBehaviourBit[aField.id]
Sounds like a good idea as well :)
Assignee | ||
Comment 6•16 years ago
|
||
This patch is updated for Neil's previous comments.
Attachment #357124 -
Attachment is obsolete: true
Attachment #357178 -
Flags: superreview?(neil)
Attachment #357178 -
Flags: review?(neil)
Attachment #357124 -
Flags: superreview?(neil)
Attachment #357124 -
Flags: review?(neil)
Updated•16 years ago
|
Attachment #357178 -
Flags: superreview?(neil)
Attachment #357178 -
Flags: superreview+
Attachment #357178 -
Flags: review?(neil)
Attachment #357178 -
Flags: review+
Assignee | ||
Comment 7•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0a3
Comment 8•16 years ago
|
||
V.Fixed, "per" bug 472978 tests.
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•