Closed
Bug 474421
Opened 16 years ago
Closed 16 years ago
Qt Widget no longer compiles in testplugin
Categories
(Core Graveyard :: Widget: Qt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: johnflux, Assigned: johnflux)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.0.5) Gecko/2008121622 Ubuntu/8.10 (intrepid) Firefox/3.0.5
Build Identifier:
Qt Widget no longer compiles after bug fix for 448830. The bug changed nsRect to nsIntRect in various functions, but did not update the qt widgets.
Reproducible: Always
Steps to Reproduce:
Try to compile with --enable-default-toolkit=cairo-qt
Actual Results:
Compile failure
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #357787 -
Flags: review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
This just follows the changes that were made to gtk2.
Both this and the previous patch need to be committed for Qt to compile again
|
||
Updated•16 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
|
|
Assignee | |
Updated•16 years ago
|
Attachment #357788 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•16 years ago
|
||
Hi, sorry, reopening for the first patch I supplied. This patch is still required for fixing testplugin.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
|
|
Assignee | |
Updated•16 years ago
|
Summary: Qt Widget no longer compiles after bug fix for 448830 → Qt Widget no longer compiles in testplugin
|
|
Assignee | |
Updated•16 years ago
|
Attachment #357787 -
Flags: review+ → review?(joshmoz)
Comment on attachment 357787 [details] [diff] [review]
Minor fix for getting the tests compiling
[Checkin: Comment 6]
I don't know how qt plugins are supposed to draw, but even if this patch worked the reftests will fail. Its a start though.
Attachment #357787 -
Flags: review?(joshmoz) → review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Updated•16 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Updated•16 years ago
|
Assignee: nobody → johnflux
|
||
Comment 6•16 years ago
|
||
Comment on attachment 357787 [details] [diff] [review]
Minor fix for getting the tests compiling
[Checkin: Comment 6]
http://hg.mozilla.org/mozilla-central/rev/870843e43abe
Attachment #357787 -
Attachment description: Minor fix for getting the tests compiling → Minor fix for getting the tests compiling
[Checkin: Comment 6]
|
|
||
Comment 7•16 years ago
|
||
(In reply to comment #5)
> the reftests will fail. Its a start though.
R.Fixed for now: reopen or file a new bug, as needed.
Status: NEW → RESOLVED
Closed: 16 years ago → 16 years ago
Depends on: 448830
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•