Closed
Bug 474769
Opened 16 years ago
Closed 16 years ago
TM: wrong number with nested type-unstable loops
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: jruderman, Assigned: dvander)
References
Details
(Keywords: regression, testcase, verified1.9.1)
Attachments
(1 file)
|
(deleted),
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
for each (b in [1, 1, 1, 1.5, 1, 1]) {
(function() { for each (let h in [0, 0, 1.4, ""]) {} })()
}
print(b);
Result: -6.2774359784998874e+66
Expected: 1
Regression from bug 469044, I think.
|
Assignee | |
Updated•16 years ago
|
Assignee: general → danderson
|
|
Assignee | |
Comment 1•16 years ago
|
||
Looks like two incompatible peers are being linked somewhere, it's trying to unbox 0x00000001 0xCDCDCDCD as a double whereas it's 0x1 as an integer.
|
|
Assignee | |
Comment 2•16 years ago
|
||
missing break tried to patch the same branch twice. also, fixed a small memory leak.
Attachment #358320 -
Flags: review?(gal)
|
||
Comment 3•16 years ago
|
||
Comment on attachment 358320 [details] [diff] [review]
proposed fix
Nice. I think someone actually reported this leak as "leak in chrome".
Attachment #358320 -
Flags: review?(gal) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Pushed fix as changeset: http://hg.mozilla.org/tracemonkey/rev/349fab40252a
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 5•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/9a4f1433c04b
/cvsroot/mozilla/js/tests/js1_8/regress/regress-474769.js,v <-- regress-474769.js
initial revision: 1.1
Flags: in-testsuite+
Flags: in-litmus-
|
||
Comment 6•16 years ago
|
||
Flags: wanted1.9.1+
|
|
||
Comment 7•16 years ago
|
||
Keywords: fixed1.9.1
|
|
||
Comment 8•16 years ago
|
||
|
|
||
Comment 9•16 years ago
|
||
v 1.9.1, 1.9.2
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•