Per bug 456984 c62

The drop functionality needs to also be restored.

This should do it.

What do we need the dragover attribute for?

(In reply to comment #4) > What do we need the dragover attribute for? No idea, but it was there before... I'll try to dig into it. (It's currently on trunk as well).

It seems to be used in toolbox, although I'm not 100% sure if it's really needed.

If you mean customizeToolbar.js, then that's a different thing. It sets dragover="left" / dragover="right" on the toolbarpaletteitem.

Comment on attachment 359166 [details] [diff] [review] patch We can file a followup to find out whether dragover is needed, but let's play it safe for now on the branch and just restore things as they were.

(FIXED just to indicate that it's not relevant to trunk)

The mozilla-1.9.1 tree is open for string changes again. Please make sure the bug stays marked as latel10n, and check in when the tree is green!

Verified fixed on 1.9.1 with builds on OS X and Windows: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3 ID:20090305133223

Any chance that this caused a Ts regression on OSX: http://graphs-new.mozilla.org/#tests=[{%22test%22:%2216%22,%22branch%22:%223%22,%22machine%22:%2236%22}]&sel=1236381876,1236465509

Don't see how it could, the code doesn't ever run (aside from being "compiled") at startup. The only difference between trunk and branch afaik is the setAttribute call which was removed (and deemed useless) in bug 477694. Again, that code doesn't even run at startup, and was there before, this bug was just a restoration.

Hey Natch, I hear what you're saying about it being phenomenally unlikely, but there's only three bugs in the window, one of which has had a trial backout before, and the other of which I just backed out. So this is the next one to try, just in case. http://hg.mozilla.org/releases/mozilla-1.9.1/rev/98e52788513a - Partial backout of bug 474917 (strings stay put) as part of tracking down Ts regression on OSX - tracked by bug 486236 Removing verified-1.9.1. Sorry for the annoyance.

This backout does not seem to have remedied the regression on the 8.8.4 fast talos box, which has been a pretty reliable canary so far: http://graphs-new.mozilla.org/graph.html#tests=[{%22test%22:%2216%22,%22branch%22:%223%22,%22machine%22:%2249%22}] (Should have posted this last night, but apparently it didn't go?)

Verified relanding with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090405 Shiretoko/3.5b4pre ID:20090405033410 and on Windows.