Closed Bug 475082 Opened 16 years ago Closed 16 years ago

New Tab button should look like a background tab on OS X

Categories

(Firefox :: Theme, defect, P2)

Product:
Firefox
Component:
Theme
Version:
3.5 Branch
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.6a1

People

(Reporter: sdwilsh, Assigned: dao)

References

Details

(Keywords: verified1.9.1)

Attachments

(3 files, 3 obsolete files)

screenshot
(deleted), image/png
Details
tab-like appearance
(deleted), patch
Gavin
: review+
Details | Diff | Splinter Review
screenshot with patch for tab-like appearance
(deleted), image/png
faaborg
: ui-review+
Details
Regression from bug 457651. The tab button looks as wide as the space available, so if you have few tabs, it looks really wide.
Flags: blocking-firefox3.1?
Priority: -- → P1
I mentioned in the other bug a while back... perhaps we could have it "be" super wide but look small. This gets rid of the need to double click the empty space -- a single click to a super wide new tab button would be convenient. Kinda like the big back button... but more so for the forward button (where it looks small but the hit target is actually the same as the back).
(In reply to comment #1) > I mentioned in the other bug a while back... perhaps we could have it "be" > super wide but look small. This gets rid of the need to double click the empty > space -- a single click to a super wide new tab button would be convenient. All other platforms have a small button. I think for the beta we should fix it to be consistent, and have this conversation some other time.
Attached image screenshot (deleted) —
What /does/ it look like on other platforms?
Attached patch patch (obsolete) (deleted) — — Splinter Review
Attached image screenshot with border fixed (obsolete) (deleted) —
Attached patch fix border (obsolete) (deleted) — — Splinter Review
Attachment #358486 - Attachment is obsolete: true
Comment on attachment 358490 [details] [diff] [review] fix border r=sdwilsh
Attachment #358490 - Flags: review+
Version: unspecified → Trunk
Given bug 457651 comment 111, I'm not sure if it's worth taking this patch.
Component: General → Theme
QA Contact: general → theme
Version: Trunk → 3.1 Branch
Attached patch tab-like appearance (deleted) — — Splinter Review
I could file a new bug, but it would probably make a lot sense to just merge this bug.
So we wanna put the new tab button directly behind the last open tab now? Means using the button to open a couple of tabs will not be as easy as it is currently.
(In reply to comment #12) > So we wanna put the new tab button directly behind the last open tab now? See bug 457651.
Comment on attachment 358607 [details] [diff] [review] tab-like appearance What's the image change?
Attachment #358607 - Flags: review+
Assignee: gavin.sharp → dao
Keywords: checkin-needed
Attachment #358490 - Attachment description: real patch → fix border
Attachment #358490 - Attachment is obsolete: true
Attachment #358487 - Attachment description: screenshot with patch → screenshot with border fixed
Attachment #358487 - Attachment is obsolete: true
(In reply to comment #14) > (From update of attachment 358607 [details] [diff] [review]) > What's the image change? It makes the icon monochrome (also mentioned in bug 457651). It's still not final, though.
Blocks: 468839
Keywords: checkin-needed
Attachment #358607 - Flags: approval1.9.1?
Summary: New tab button looks massively wide → New Tab button should look like a background tab on OS X
Attachment #358607 - Flags: approval1.9.1?
Comment on attachment 358607 [details] [diff] [review] tab-like appearance Given bug 457651 comment 108, I'll just land it...
Verified on trunk and 1.9.1 with: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090126 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090126020313 Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090126 Minefield/3.2a1pre ID:20090126020316
Status: RESOLVED → VERIFIED
Flags: blocking-firefox3.1?
Keywords: fixed1.9.1 → verified1.9.1
Leaving blocking request. This landed without approval.
Flags: blocking-firefox3.1?
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Priority: P1 → P2
No longer blocks: 468839
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: