User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090124 Minefield/3.2a1pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090124 Minefield/3.2a1pre The -moz-box-shadow property does not work on input elements. It does work in Safari 3.2.1 Reproducible: Always See attached file. I have made the button using a div so you can see how it should look. Also included the -webkit-box-shadow property, so you can see it render in webkit.

Same problem with <button>

Yep. Buttons don't call nsFrame::DisplayBorderBackgroundOutline; they do special border/background/outline painting. See nsHTMLButtonControlFrame::BuildDisplayList. Michael, want to fix this?

I also fixed things for fieldset considering it uses its own callers as well.

Is there a way to reftest this? At least a != test with the same but without text/shadow... With buttons you might be able to use divs as the reference.

Pushed http://hg.mozilla.org/mozilla-central/rev/777f55d55ccc and http://hg.mozilla.org/mozilla-central/rev/daca86bf5d85.

Should the box-shadow apply when the form-control is otherwise unstyled (aka native) ? The native widgets in attachment (id=358660) look pretty ugly on OS X. WebKit/Safari (on OS X 10.5.6 at least) drops the box-shadow unless the author has styled the widget (border, background etc).

attachment (id=358660) in WebKit (left) and Minefield (20090128 build).

> WebKit/Safari (on OS X 10.5.6 at least) drops the box-shadow I suspect that's an artifact of their rendering codepaths, just like this bug was an artifact of ours. Per current spec, there should certainly be a box-shadow there...

Yeah, that's just a Webkit bug. If we wanted to do something here, we would treat box-shadow as author style and drop the native look for widgets with shadows.

(In reply to comment #9) > WebKit/Safari (on OS X 10.5.6 at least) drops the box-shadow Safari and Chrome draw the shadow on Win XP, except for "radio" and "checkbox".

(In reply to comment #13) > (In reply to comment #9) > > WebKit/Safari (on OS X 10.5.6 at least) drops the box-shadow > > Safari and Chrome draw the shadow on Win XP, except for "radio" and "checkbox". Ah, thanks, I hadn't tested on Windows. (In reply to comment #12) > If we wanted to do something here, we would treat box-shadow as author style > and drop the native look for widgets with shadows. That is what I actually would have expected. And it is what I suspect WebKit Mac actually does, and I didn't find any bug in their database unless it is in rdar. Note, I doubt authors would actually use box-shadow without any other styling on form controls.

Alright, please file a followup bug for that. You can assign it to Michael.

Sorry but the shadows for buttons aren't entirely there. I still miss the shadow for the browse button of the <input type=file> elements. There is no shadow drawn. Tested with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090129 Minefield/3.2a1pre ID:20090129020336

Can you file a new bug for that? We probably need -moz-box-shadow:inherit on the anonymous button and textbox for file inputs.

This is all we really can do considering we do some kind fo clipping on the file control frame...

Reftests: roc loves them, I have to make them :/

Pushed file upload control patch to trunk: http://hg.mozilla.org/mozilla-central/rev/00f74e51fe52

Comment on attachment 359624 [details] [diff] [review] Also fix file uploaders Simple fix for a bug in a new feature

Comment on attachment 358976 [details] [diff] [review] [checked-in] Patch Simple fix for a bug in a new feature

This caused bug 476308. Please don't land on 1.9.1 until that's resolved?

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8be6f1f1bb3c http://hg.mozilla.org/releases/mozilla-1.9.1/rev/80a57a22c967 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/23adc0bc597d I forgot to land 476308 at the same time, but that fix is ready to land and should be pushed to 1.9.1 ASAP.

(In reply to comment #10) > Created an attachment (id=359253) [details] > screenshot testcase 3 Roc, why we still have this ugly white backgrounds for buttons which can also be seen in this screenshot? Shouldn't this be fixed too?

Yes, can you please file a new bug for comment #12?

(In reply to comment #26) > Yes, can you please file a new bug for comment #12? that is bug 476062, right ?

Yes thanks!

Ah, missed that bug. Sorry. Ok, otherwise that looks good. Verified fixed with builds on OS X and Windows: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090227 Minefield/3.2a1pre Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090227 Shiretoko/3.1b3pre ID:20090227020413