Closed
Bug 475200
Opened 16 years ago
Closed 16 years ago
Junk controls don't work in standalone message window
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a3
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(1 file)
(deleted),
patch
|
standard8
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Junk controls in the standalone message window either die silently or throw this error:
Error: JunkSelectedMessages is not defined
Source File: chrome://messenger/content/messageWindow.xul
Line: 1
When I debugged it with Venkman, executing controller.doCommand("button_junk") while being in goDoCommand(), I got this exception:
Caught exception: “[Exception... "'[JavaScript Error: "JunkSelectedMessages is not defined" {file: "chrome://messenger/content/mailWindowOverlay.js" line: 1438}]' when calling method: [nsIController::doCommand]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: x-jsd:interactive-session :: goDoCommand :: line 1" data: yes]”
So somehow the functions in junkCommands.js seem to be missing in the standalone window.
Comment 1•16 years ago
|
||
Seems like SeaMonkey includes junkCommands.js only in messenger.xul, while TB includes it in mailWindowOverlay.xul, overlaying both messenger.xul and messageWindow.xul...
Assignee | ||
Comment 2•16 years ago
|
||
The patch moves the include of junkCommands.js from messenger.xul to mailWindowOverlay.xul, making the junk commands available in both the 3 pane view and the standalone message window.
Assignee: nobody → aqualon
Status: NEW → ASSIGNED
Attachment #358701 -
Flags: superreview?(neil)
Attachment #358701 -
Flags: review?(bugzilla)
Assignee | ||
Updated•16 years ago
|
Updated•16 years ago
|
Attachment #358701 -
Flags: superreview?(neil) → superreview+
Updated•16 years ago
|
Attachment #358701 -
Flags: review?(bugzilla) → review+
Comment 3•16 years ago
|
||
Pushed to comm-central, changeset 3fc9e562a8ee
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•