Comment on attachment 358825 [details] [diff] [review] patch >+ // 'described by'/'descrption for' relation for html:table and Nit: "Description" misses an i. + <input id="checkbox1"> In this and the below cases, please end with /> if you don't include other thags within. Looks cleaner if you get the feeling the tag actually ends there and doesn't contain any other tags. >+ <span id="label2">label</label> > + <span id="descr1">description</label> The ending tags should be </div> here, right? >+ <div role="treeitem" id="treeitem1">Yellow<div> Missing / in closing tag. >+ <form> >+ <input id="input"> >+ <input type="submit" id="submit"> >+ </form> Again I'd prefer if you closed the tags, same with the html:input element in the fieldset. Also, please remove the unrelated tree changes from test_bug368835.xul and the according entry in Makefile.in for tree.js. They are not related to this bug. With those changes: r=me.

marco's comments are adressed

right patch

Comment on attachment 358841 [details] [diff] [review] patch3 r=me >+const RELATION_CONTROLLED_BY = nsIAccessibleRelation.RELATION_CONTROLLED_BY; >+const RELATION_CONTROLLER_FOR = nsIAccessibleRelation.RELATION_CONTROLLER_FOR; >+const RELATION_LABEL_FOR = nsIAccessibleRelation.RELATION_LABEL_FOR; >+const RELATION_LABELLED_BY = nsIAccessibleRelation.RELATION_LABELLED_BY; >+const RELATION_MEMBER_OF = nsIAccessibleRelation.RELATION_MEMBER_OF; >+const RELATION_NODE_CHILD_OF = nsIAccessibleRelation.RELATION_NODE_CHILD_OF; >+const RELATION_FLOWS_TO = nsIAccessibleRelation.RELATION_FLOWS_TO; >+const RELATION_FLOWS_FROM = nsIAccessibleRelation.RELATION_FLOWS_FROM; >+const RELATION_SUBWINDOW_OF = nsIAccessibleRelation.RELATION_SUBWINDOW_OF; >+const RELATION_EMBEDS = nsIAccessibleRelation.RELATION_EMBEDS; >+const RELATION_EMBEDDED_BY = nsIAccessibleRelation.RELATION_EMBEDDED_BY; >+const RELATION_POPUP_FOR = nsIAccessibleRelation.RELATION_POPUP_FOR; >+const RELATION_PARENT_WINDOW_OF = nsIAccessibleRelation.RELATION_PARENT_WINDOW_OF; >+const RELATION_DESCRIBED_BY = nsIAccessibleRelation.RELATION_DESCRIBED_BY; >+const RELATION_DESCRIPTION_FOR = nsIAccessibleRelation.RELATION_DESCRIPTION_FOR; >+const RELATION_DEFAULT_BUTTON = nsIAccessibleRelation.RELATION_DEFAULT_BUTTON; Nit: I would prefer these in alphabetic order to match http://accessibility.freestandards.org/a11yspecs/ia2/api/AccessibleRelation.idl so down the road it will be easier to sync with any spec modifications. >+//////////////////////////////////////////////////////////////////////////////// >+// Private implementation details ;)