Closed Bug 47551 Opened 24 years ago Closed 23 years ago

Remove nsIFileSpecWithUI and nsIFileWidget

Categories

(Core :: XUL, defect, P5)

Product:
Core
Component:
XUL
Platform:
x86
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.5

People

(Reporter: pavlov, Assigned: bryner)

References

Details

Attachments

(2 files, 1 obsolete file)

files to be removed
(deleted), text/plain
Details
patch
(deleted), patch
pavlov
: review+
bugs
: superreview+
Details | Diff | Splinter Review
Remove nsIFileSpecWithUI so that no one can use it ever again.
Status: NEW → ASSIGNED
Depends on: 34051
Keywords: correctness, nsbeta3
Summary: Remove nsIFileSpecWithUI → Remove nsIFileSpecWithUI and nsIFileWidget
No longer depends on: 34051
Depends on: 47552
Depends on: 34051
Depends on: 47553
Depends on: 39234
nsbeta3+, P5 for M18
Priority: P3 → P5
Whiteboard: [nsbeta3+]
Target Milestone: --- → M18
Index: nsAppRunner.cpp =================================================================== RCS file: /cvsroot/mozilla/xpfe/bootstrap/nsAppRunner.cpp,v retrieving revision 1.232 diff -u -r1.232 nsAppRunner.cpp --- nsAppRunner.cpp 2000/08/25 18:37:45 1.232 +++ nsAppRunner.cpp 2000/08/28 20:09:08 @@ -1139,7 +1139,7 @@ nsresult mainResult = main1(argc, argv, nativeApp ? (nsISupports*)nativeApp : (nsISupports*)splash); /* if main1() didn't succeed, then don't bother trying to shut down clipboard, etc */ - if (NS_SUCCEEDED(rv)) { + if (NS_SUCCEEDED(mainResult)) { rv = DoOnShutdown(); NS_ASSERTION(NS_SUCCEEDED(rv), "DoOnShutdown failed"); }
er, wrong bug. sigh
nsbeta3-/future
Whiteboard: [nsbeta3+] → [nsbeta3-]
Target Milestone: M18 → Future
Simon says he has the fixes for the mac that were blocking this landing.
Keywords: nsbeta3
Whiteboard: [nsbeta3-]
Target Milestone: Future → mozilla0.8
Depends on: 66036
Target Milestone: mozilla0.8 → mozilla0.9
Target Milestone: mozilla0.9 → mozilla1.0
I'll take this.
Assignee: pavlov → bryner
Blocks: 93467
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0 → mozilla0.9.5
Attached patch patch (obsolete) (deleted) — — Splinter Review
Attached file files to be removed (deleted) —
need to add #include <String.h> to widget/src/beos/nsFilePicker.h
Attachment #47947 - Attachment is obsolete: true
Attached patch patch (deleted) — — Splinter Review
The new patch incorporates cls's beos fix.
Comment on attachment 48016 [details] [diff] [review] patch r=pavlov
Attachment #48016 - Flags: review+
checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: