See bug 469408 comment 4. Bug 449159 introduced a bug into liboggplay where the guess for the byte position to seek too is often incorrect. This causes many unnecessary byte range requests when seeking via HTTP and slows seeks down a lot.

This should be blocking1.9.1+ I think due to the impact it has on seek times.

Is this patch ready for review?

Comment on attachment 359237 [details] [diff] [review] liboggz fix for guessing seek position Robert, are you happy to review this change or would you prefer I try and get an annodex person to look at it?

Comment on attachment 359237 [details] [diff] [review] liboggz fix for guessing seek position Ok to land. But please get an annodex person to review it upstream as well. Thanks.

Preparing this for landing tonight I noticed that all the tests pass, but is it my imagination or does the test that plays the space invaders sound have the sound cutoff? It seems to play about twice as long without this patch. I'll investigate, in the meantime I've removed the needs landing whiteboard.

Bug 477899 contains the fix that the fix to this bug triggers. After requesting the duration liboggplay seeks back to a position that is past the first part of the audio sample.

(In reply to comment #6) > Bug 477899 contains the fix that the fix to this bug triggers. Can this land now?

Patch in bug 469408 contains the fix in doublec's patch. We can take the patch in bug 469408 instead of the one here.

I'm making this a dup of 469408 because that's where this will get fixed.