Closed
Bug 475901
Opened 16 years ago
Closed 16 years ago
nsIAccessibleValue interface changed without change uuid
Categories
(Core :: Disability Access APIs, defect, P1)
Core
Disability Access APIs
Tracking
()
VERIFIED
FIXED
People
(Reporter: pjemen, Assigned: bzbarsky)
References
Details
(Keywords: verified1.9.1)
Attachments
(1 file)
(deleted),
patch
|
MarcoZ
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5 XPCOMViewer/1.0a1
Build Identifier:
nsIAccessibleValue
readonly atribute removed: attribute double
removed method: boolean setCurrentValue (in double value);
Reproducible: Always
Actual Results:
old uuid
Expected Results:
new uuid
Reporter | ||
Updated•16 years ago
|
Flags: wanted-thunderbird3?
Updated•16 years ago
|
Component: General → Disability Access APIs
Flags: wanted-thunderbird3?
Product: Thunderbird → Core
QA Contact: general → accessibility-apis
Updated•16 years ago
|
Comment 1•16 years ago
|
||
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #359484 -
Flags: review?(marco.zehe)
Updated•16 years ago
|
Flags: blocking1.9.1?
Updated•16 years ago
|
Flags: blocking1.9.0.7?
Updated•16 years ago
|
Attachment #359484 -
Flags: review?(marco.zehe) → review+
Assignee | ||
Comment 2•16 years ago
|
||
Do we actually want to make a change like that on the stable branch?
Comment 3•16 years ago
|
||
(In reply to comment #2)
> Do we actually want to make a change like that on the stable branch?
Can it prevent the work of 3d party XPCOM components?
Comment 4•16 years ago
|
||
3rd-party components are already screwed, because they can't tell the difference between the old version and the new version. Changing the UUID now, after we have a release which is "broken", doesn't seem like it would help much.
Comment 5•16 years ago
|
||
Should we fix this at all?
Assignee | ||
Comment 6•16 years ago
|
||
"good question".
Revving the iid for 1.9.1 might be a good idea. It'll cause a bit more hassle for someone trying to support 1.9.1 and 1.9.0, but make it easier to support both 1.9.0 and 1.8.x....
Comment 7•16 years ago
|
||
I don't think it'll help with 1.9.0 and 1.8.x, since those version have different interfaces with the same UUID. I think this should be WONTFIX.
Assignee | ||
Comment 8•16 years ago
|
||
er, I meant 1.9.1 and 1.8.x.
Assignee | ||
Comment 9•16 years ago
|
||
As reporter points out in the newsgroup, for tbird this would in fact help with 1.9.0 vs 1.8. What a mess. :(
Comment 10•16 years ago
|
||
I wonder if we can catch these bugs earlier, perhaps with some source code analyzer that checks for stale uuids?
Assignee | ||
Comment 11•16 years ago
|
||
See discussion in .platform.
Comment 12•16 years ago
|
||
tbird is shipping off 1.9.1, not 1.9.0. Clearing flag because I think the 1.9.0 nomination was based on that mistaken idea. In any case it's not going to make 1.9.0.7
Flags: blocking1.9.0.7?
Updated•16 years ago
|
Assignee: surkov.alexander → bzbarsky
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P1
Assignee | ||
Comment 13•16 years ago
|
||
Comment 14•16 years ago
|
||
Seeing as there hasn't been any discussions about this bug for 2 months, I'm guessing there aren't any residual issues. I'm moving this to verified as a result. If anyone has any qualms, feel free to bring them up.
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•