Closed
Bug 476163
Opened 16 years ago
Closed 16 years ago
consolidate makefile cruft for generating automation.py
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: ted, Assigned: ted)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Currently we have three consumers of automation.py in the tree, and they all copy-paste the Makefile logic needed to preprocess it. This is pretty awful. I'd like to make this a lot better, but right now I'll settle for making it not awful. This patch just creates build/automation-build.mk which the various Makefiles can include to generate automation.py. At least this keeps the Makefile cruft in one central location. Oh, also, it moves automation.py.in from build/pgo to build/, because although it's used in the pgo script, that's not its sole purpose.
Attachment #359755 -
Flags: review?(benjamin)
|
Assignee | |
Comment 1•16 years ago
|
||
Instead of using $(DIST) at all in the preprocessor bits, make consumers specify a TARGET_DEPTH variable, so they can indicate the depth at which automation.py will get installed to in the objdir.
Assignee: nobody → ted.mielczarek
Attachment #359755 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #359762 -
Flags: review?(benjamin)
Attachment #359755 -
Flags: review?(benjamin)
|
||
Updated•16 years ago
|
Attachment #359762 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/ee4fde1683df
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Whiteboard: [needs 1.9.1 landing]
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
|
|
||
Updated•16 years ago
|
Whiteboard: [needs 1.9.1 landing] → [needs 1.9.1 landing: after bug 472706]
|
|
Assignee | |
Comment 3•16 years ago
|
||
Pushed to 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d06c533a8d5d
Keywords: fixed1.9.1
Whiteboard: [needs 1.9.1 landing: after bug 472706]
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•