Sijmen Reporter
	Description • 16 years ago

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; nl; rv:1.9.0.5) Gecko/2008120121 Firefox/3.0.5 Ubiquity/0.1.5
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; nl; rv:1.9.0.5) Gecko/2008120121 Firefox/3.0.5 Ubiquity/0.1.5

I've enabled advanced keyboard navigation in System Preferences to be able to use my keyboard to navigate around applications. While this works for most of Firefox too, the buttons on the information bar with the question whether or not to save my password do not show a focus ring when they are selected. If I count my TABs, I can still use them (pressing spacebar works when they have focus).

Reproducible: Always

Steps to Reproduce:
1. Login to a site, and wait for the information bar with the question whether or not to save the password.
2. Command+L to go the location bar.
3. Press TAB twice: once to go from the location bar to the search field, then once again to go from the tab bar to the first button on the information bar.
4. Press spacebar.
Actual Results:  
At step 3, the button with focus is not highlighted. Step 4 works, and the button is pressed.

Expected Results:  
A focus ring should show up around the button.

	Markus Stange [:mstange]
	Comment 1 • 16 years ago

If we add focus rings to these buttons, they'll also appear when they're clicked with the mouse (this is caused by Gecko's un-Macish focus-on-mousedown behaviour, bug 418521).
And in my opinion, focus rings on notification bar buttons that appear when clicked look really strange... but that's probably something we'll have to live with until bug 418521 is fixed.

	Dão Gottwald [:dao] Assignee
	Comment 2 • 16 years ago

How about a color change instead of a focus ring? Isn't that how the native aqua buttons behave?

	Markus Stange [:mstange]
	Comment 3 • 16 years ago

The color change usually only happens while the button is pressed. The exception are dialog default buttons which pulsate in a blue color even when they're not pressed.

Another idea would be to hide the focus ring while the button is pressed - then it would only appear when the button has already been released, i.e. when the notification bar is already fading away.

However, this idea wouldn't really work for the buttons in the find bar (for which we don't show a focus ring right now, either).

	Dão Gottwald [:dao] Assignee
	Comment 4 • 16 years ago

OK, so I really don't know how focus is indicated on native Mac buttons, but we should do the same here, with this possible optimization:

> Another idea would be to hide the focus ring while the button is pressed - then
> it would only appear when the button has already been released, i.e. when the
> notification bar is already fading away.

This shouldn't be a requirement, though. In contrast, accessibility should be a requirement for making theme changes, so this shouldn't have been broken in the first place.

	Neil Deakin
	Comment 7 • 16 years ago

Why is this patch implementing some special mouseclick button focus ring behaviour? We should do that in bug 418521, not make some special case just for this one button.

	Dão Gottwald [:dao] Assignee
	Comment 8 • 16 years ago

No special reason, but it was suggested in comment 13. I can't take that out.

	Dão Gottwald [:dao] Assignee
	Comment 9 • 16 years ago

:not(:active) removed

	Dão Gottwald [:dao] Assignee
	Comment 10 • 16 years ago

http://hg.mozilla.org/mozilla-central/rev/a3dc9e28deee

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 11 • 15 years ago

Comment on attachment 367293 [details] [diff] [review]
patch v3

a191=beltzner

	Dão Gottwald [:dao] Assignee
	Comment 12 • 15 years ago

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8a574b184b25

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 13 • 15 years ago

Verified fixed with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090408 Minefield/3.6a1pre ID:20090408030741

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090409 Shiretoko/3.5b4pre ID:20090409031809

	Alex Faaborg [:faaborg] (Firefox UX)
	Comment 14 • 15 years ago

This bug's priority relative to the set of other polish bugs is:
P4 - Polish issue that is rarely encountered, and is easily identifiable.