Closed
Bug 476372
Opened 16 years ago
Closed 16 years ago
lots of "ASSERTION: We placed a float where there was no room" running content/base/test mochitests
Categories
(Core :: Layout: Floats, defect)
Core
Layout: Floats
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b3
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
When running the mochitests in content/base/test, there are a lot of assertions of the form:
###!!! ASSERTION: We placed a float where there was no room!: 'psd->mX - mTrimmableWidth <= psd->mRightEdge', file /home/dbaron/builds/bisect-mozilla-central/mozilla/layout/generic/nsLineLayout.cpp, line 345
These are a regression from the float manager landing (bug 191448). I tested this by observing that the assertions were not present with a build from http://hg.mozilla.org/mozilla-central/rev/b087a09f82aa but are present with a build from http://hg.mozilla.org/mozilla-central/rev/aa32889429db with the patches from http://hg.mozilla.org/mozilla-central/rev/63fc1585fe00 , http://hg.mozilla.org/mozilla-central/rev/c162278affad , and http://hg.mozilla.org/mozilla-central/rev/2a4999efa837 patched in.
Assignee | ||
Comment 1•16 years ago
|
||
Note that there are some comments about this bug in bug 439204.
Assignee | ||
Comment 2•16 years ago
|
||
I think they're mainly on 416317-2.html, but maybe some on 416317-1.html.
Assignee | ||
Comment 3•16 years ago
|
||
I think the difference is that in the old code, GetAvailableSpace conditioned the band width to be >= 0, whereas now we're ending up with negative available space widths.
Assignee | ||
Comment 4•16 years ago
|
||
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #360009 -
Flags: superreview?(roc)
Attachment #360009 -
Flags: review?(roc)
Attachment #360009 -
Flags: superreview?(roc)
Attachment #360009 -
Flags: superreview+
Attachment #360009 -
Flags: review?(roc)
Attachment #360009 -
Flags: review+
Assignee | ||
Comment 5•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Assignee | ||
Comment 6•16 years ago
|
||
Landed on 1.9.1 along with the patch that caused the regression:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/110384dabb87
Keywords: fixed1.9.1
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b3
Updated•16 years ago
|
Flags: wanted1.9.0.x+
Flags: blocking1.9.0.12+
Updated•16 years ago
|
Flags: wanted1.9.0.x+
Flags: blocking1.9.0.12+
You need to log in
before you can comment on or make changes to this bug.
Description
•