Closed
Bug 476967
Opened 16 years ago
Closed 16 years ago
Strict warning "assignment to undeclared variable" does not work in browser (works in js shell)
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: mrbkap)
Details
(Keywords: fixed1.9.1, regression)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jst
:
review+
jst
:
superreview+
jst
:
approval1.9.1+
|
Details | Diff | Splinter Review |
This warning is pretty important for finding potential compatibility bugs in Firefox, extensions, and Greasemonkey scripts. mrbkap explained to me why it doesn't work in the browser and has ideas about how to make it work again.
|
Reporter | |
Updated•16 years ago
|
Summary: "assignment to undeclared variable" does not work in browser (works in js shell) → Strict warning "assignment to undeclared variable" does not work in browser (works in js shell)
|
Assignee | |
Comment 1•16 years ago
|
||
I noticed that we're swallowing strict warnings right now. The check in NS_ScriptErrorReporter eagerly reports warnings that would otherwise be swallowed.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #360842 -
Flags: superreview?(jst)
Attachment #360842 -
Flags: review?(jst)
|
|
Assignee | |
Comment 2•16 years ago
|
||
It turned out that the warning *was* being correctly reported all along. We don't have to do any additional work there, just report warnings eagerly.
Attachment #360842 -
Attachment is obsolete: true
Attachment #361390 -
Flags: superreview?(jst)
Attachment #361390 -
Flags: review?(jst)
Attachment #360842 -
Flags: superreview?(jst)
Attachment #360842 -
Flags: review?(jst)
|
||
Updated•16 years ago
|
Attachment #361390 -
Flags: superreview?(jst)
Attachment #361390 -
Flags: superreview+
Attachment #361390 -
Flags: review?(jst)
Attachment #361390 -
Flags: review+
|
|
||
Comment 3•16 years ago
|
||
Comment on attachment 361390 [details] [diff] [review]
patch v2
This could use some manual testing both with strict warnings enabled and not before landing...
|
|
||
Updated•16 years ago
|
Attachment #361390 -
Flags: approval1.9.1+
|
|
Assignee | |
Comment 4•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/66c6469a7c92
Note that there are a few strict warnings in chrome that are now being reported that were previously suppressed. They will need their own investigation and resolution.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 6•16 years ago
|
||
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•