Closed
Bug 477465
Opened 16 years ago
Closed 15 years ago
Move JS code out of flag/list.html.tmpl
Categories
(Bugzilla :: Attachments & Requests, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: LpSolit, Assigned: LpSolit)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
Should probably go into a new js/flag.js file.
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [Good Intro Bug]
|
|
Assignee | |
Comment 2•16 years ago
|
||
Comment on attachment 364544 [details] [diff] [review]
Add flag.js and change flag/list.html.tmpl
>+++ ./js/flag.js 2009-02-24 12:06:24.000000000 -0500
Please add the license block to the JS file, see e.g. the one in js/util.js.
>+++ ./template/en/default/flag/list.html.tmpl 2009-02-24 12:17:49.000000000 -0500
>+<script src="/js/flags.js" type="text/javascript"></script>
Please remove "/" before js.
Do not forget to request review when you update your patch, else nobody will notice it.
|
|
Assignee | |
Comment 3•15 years ago
|
||
Ges, do you want to update your patch or is your patch abandoned?
|
|
Assignee | |
Comment 4•15 years ago
|
||
Assignee: attach-and-request → LpSolit
Attachment #364544 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #414142 -
Flags: review?(mkanat)
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [Good Intro Bug]
Target Milestone: --- → Bugzilla 3.6
|
||
Comment 5•15 years ago
|
||
Comment on attachment 414142 [details] [diff] [review]
patch, v1
>+YAHOO.util.Event.addListener(window, "load", disableRequesteeFields);
Instead of hooking window.load, we should probably just make that a YAHOO.util.Event.onDomReady(disableRequesteeFields).
Also, it probably should go outside of this file.
But this looks OK to check in.
Attachment #414142 -
Flags: review?(mkanat) → review+
|
|
||
Updated•15 years ago
|
Flags: approval+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Checking in js/flag.js;
/cvsroot/mozilla/webtools/bugzilla/js/flag.js,v <-- flag.js
initial revision: 1.1
done
Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v <-- list.html.tmpl
new revision: 1.39; previous revision: 1.38
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•