Jesse Ruderman Reporter
	Description • 15 years ago

###!!! ASSERTION: bits don't correspond to style change reason: 'aIntrinsicDirty != eStyleChange || aBitToAdd == NS_FRAME_IS_DIRTY', file /Users/jruderman/central/layout/base/nsPresShell.cpp, line 3126

	Boris Zbarsky [:bzbarsky]
	Comment 1 • 15 years ago

nsBlockFrame::AttributeChanged makes exactly the sort of calls this assertion is supposed to catch.

As far as I can see, it shouldn't be using eStyleChange here.  In fact, it should probably not be doing anything at all; it would make more sense for the guts of RenumberLists to actually call FrameNeedsReflow on whatever bullets they change.  The only issue there is that our setup for marking lines dirty is really slow, so we don't actually want to make such calls....

On the other hand, there's also no point clearing all descendant intrinsic widths here.  Or we could just switch to NS_FRAME_IS_DIRTY for the flag; these attributes don't change much.

David, thoughts?

	David Baron :dbaron:
	Comment 2 • 10 years ago

It seem like what this caller is doing is pretty reasonable, although I suppose we could make it use eResize and then do the marking of descendant intrinsics manually just like we set the bits manually.